X-Original-To: alpine-aports@lists.alpinelinux.org
Received: from newmail.tetrasec.net (unknown [172.21.74.12])
	by lists.alpinelinux.org (Postfix) with ESMTP id 87E5A5C4237
	for <alpine-aports@lists.alpinelinux.org>; Fri, 19 Aug 2016 22:38:00 +0000 (GMT)
Received: from ncopa-macbook.copa.dup.pw (unknown [50.233.46.100])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	(Authenticated sender: n@tanael.org)
	by newmail.tetrasec.net (Postfix) with ESMTPSA id 30ABC5A0848;
	Fri, 19 Aug 2016 22:38:00 +0000 (GMT)
Date: Fri, 19 Aug 2016 15:37:58 -0700
From: Natanael Copa <ncopa@alpinelinux.org>
To: Michael Koloberdin <koloberdin@gmail.com>
Cc: alpine-aports@lists.alpinelinux.org
Subject: Re: [alpine-aports] [PATCH] testing/pdftk: new aport
Message-ID: <20160819153758.4b9d3bbd@ncopa-macbook.copa.dup.pw>
In-Reply-To: <20160808051357.2998-1-koloberdin@gmail.com>
References: <20160808051357.2998-1-koloberdin@gmail.com>
X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.28; x86_64-alpine-linux-musl)
X-Mailinglist: alpine-aports
Precedence: list
List-Id: Alpine Development <alpine-aports.lists.alpinelinux.org>
List-Unsubscribe: 
	<mailto:alpine-aports+unsubscribe@lists.alpinelinux.org?subject=unsubscribe>
List-Post: <mailto:alpine-aports@lists.alpinelinux.org>
List-Help: <mailto:alpine-aports+help@lists.alpinelinux.org?subject=help>
List-Subscribe: 
	<mailto:alpine-aports+subscribe@lists.alpinelinux.org?subject=subscribe>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Mon,  8 Aug 2016 05:13:57 +0000
Michael Koloberdin <koloberdin@gmail.com> wrote:

> ---
>  testing/pdftk/APKBUILD        | 51 +++++++++++++++++++++++++++++++++++++++++++
>  testing/pdftk/Makefile.Alpine | 20 +++++++++++++++++
>  2 files changed, 71 insertions(+)
>  create mode 100644 testing/pdftk/APKBUILD
>  create mode 100644 testing/pdftk/Makefile.Alpine
> 
> diff --git a/testing/pdftk/APKBUILD b/testing/pdftk/APKBUILD
> new file mode 100644
> index 0000000..c61382e
> --- /dev/null
> +++ b/testing/pdftk/APKBUILD
> @@ -0,0 +1,51 @@
> +# Maintainer: Michael Koloberdin <koloberdin@gmail.com>
> +pkgname=pdftk
> +pkgver=2.02
> +pkgrel=0
> +pkgdesc="Pdftk is a simple tool for doing everyday things with PDF documents"
> +url="http://www.pdfhacks.com/pdftk"
> +arch="all"
> +license="GPL"
> +depends="libgcj"

you don't need explicitly add libgcj to depends. abuild will do this
for you:

>>> pdftk*: Tracing dependencies...
        libgcj
        so:libc.musl-x86_64.so.1
        so:libgcc_s.so.1
        so:libgcj.so.17
        so:libstdc++.so.6

as you see abuild will add a depend=so:libgcj.so.17. abuild will also
make sure that whatever package that has the libgcj.so.17 will also
have a provides=so:libgcj.so.17. That way we don't need to modify the
depend="libgcj" in pdftk if the library moves to another package.

In other words: abuild manages shared libraries and you don't specify
the depend.

I removed it for you.

I also converted the Makefile.Alpine to a heredoc.

Thanks!

-nc


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---