Sender: =?UTF-8?Q?Timo_Ter=C3=A4s?= <timo.teras@gmail.com>
Date: Fri, 4 Nov 2016 09:19:17 +0200
From: Timo Teras <timo.teras@iki.fi>
To: Linus =?UTF-8?B?U3fDpGxhcw==?= <linus.swalas@borderless.se>
Cc: alpine-aports@lists.alpinelinux.org
Subject: Re: [alpine-aports] [PATCH] main/lddtree: Make lddtree canonicalize
 symlinks when resolving them.
Message-ID: <20161104091917.135d9758@vostro.util.wtbts.net>
In-Reply-To: <20161011234700.GA1247@borderlessmail>
References: <20161011234700.GA1247@borderlessmail>
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Wed, 12 Oct 2016 01:47:01 +0200
Linus Sw=C3=A4las <linus.swalas@borderless.se> wrote:

> diff --git a/main/lddtree/0001-lddtree-canonicalize-symlinks.patch
> b/main/lddtree/0001-lddtree-canonicalize-symlinks.patch new file mode
> 100644 index 0000000..ea65434
> --- /dev/null
> +++ b/main/lddtree/0001-lddtree-canonicalize-symlinks.patch
> @@ -0,0 +1,11 @@
> +--- lddtree-1.25.orig/lddtree.sh	2016-10-10
> 03:28:25.941861438 +0200 ++++ lddtree-1.25/lddtree.sh
> 2016-10-10 03:29:03.838528005 +0200 +@@ -148,7 +148,7 @@
> + 	list_existing_file "${_resolv_links}"
> + 	cd "${_resolv_links%/*}"
> + 	while [ -L "$_resolv_links" ]; do
> +-		_resolv_links=3D$(readlink "$_resolv_links")
> ++		_resolv_links=3D$(readlink -f "$_resolv_links")
> + 		case "$_resolv_links" in
> + 		/*)	_resolv_links=3D"${ROOT}${_resolv_links#/}"
> + 			cd "${_resolv_links%/*}"

Could you submit this as pull request to the upstream project first?
Would be nice to have in the commit message a description what this
fixes, or why this should be used.

Thanks.


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---