Sender: =?UTF-8?Q?Timo_Ter=C3=A4s?= <timo.teras@gmail.com>
Date: Thu, 1 Dec 2016 09:17:09 +0200
From: Timo Teras <timo.teras@iki.fi>
To: Brian Rosner <brian@brosner.com>
Cc: alpine-aports@lists.alpinelinux.org
Subject: Re: [alpine-aports] [PATCH] testing/rkt: new aport
Message-ID: <20161201091709.32303ee1@vostro>
In-Reply-To: <20161130210718.20030-1-brian@brosner.com>
References: <20161130210718.20030-1-brian@brosner.com>
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Looks pretty good. Few question below.

On Wed, 30 Nov 2016 14:07:18 -0700
Brian Rosner <brian@brosner.com> wrote:

> diff --git a/testing/rkt/APKBUILD b/testing/rkt/APKBUILD
> new file mode 100644
> index 0000000..0a22ea3
> --- /dev/null
> +++ b/testing/rkt/APKBUILD
> @@ -0,0 +1,46 @@
> +# Contributor: Brian Rosner <brian@brosner.com>
> +# Maintainer: Brian Rosner <brian@brosner.com>
> +pkgname=rkt
> +pkgver=1.20.0
> +pkgrel=0
> +pkgdesc="container engine for Linux designed to be composable,
> secure, and built on standards" +url="https://github.com/coreos/rkt"
> +arch="x86_64"

Are other arches not supported? Or this is the only thing you tested?

> +license="ASL 2.0"
> +depends=""
> +depends_dev=""
> +makedepends="$depends_dev coreutils grep gzip diffutils cpio go bc
> linux-headers wget file gnupg autoconf automake bash openssl-dev

edge is now based on libressl. Does it build against libressl-dev ?

> acl-dev xz sed" +subpackages=""
> +source="rkt-$pkgver.tar.gz::https://github.com/coreos/rkt/archive/v$pkgver.tar.gz"
> +builddir="$srcdir/rkt-$pkgver" +
> +build() {
> +	cd "$builddir"
> +	./autogen.sh
> +	./configure \
> +		--build=$CBUILD \
> +		--host=$CHOST \
> +		--prefix=/usr \
> +		--sysconfdir=/etc \
> +		--mandir=/usr/share/man \
> +		--localstatedir=/var \
> +		--enable-tpm=auto \
> +		--enable-sdjournal=auto \
> +		|| return 1
> +	make || return 1
> +}


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---