3 2

[alpine-aports] [PATCH] main/perl: restore the current compatibility

Valery Kartel
Details
Message ID
<20170213080258.28519-1-valery.kartel@gmail.com>
Sender timestamp
1486972978
DKIM signature
missing
Download raw message
Patch: +18 -4
- describe to which module belongs the script
- remove from -dev all the scripts that belong to the modules
---
 main/perl/APKBUILD | 22 ++++++++++++++++++----
 1 file changed, 18 insertions(+), 4 deletions(-)

diff --git a/main/perl/APKBUILD b/main/perl/APKBUILD
index 6ee6da23b1..6c11576848 100644
--- a/main/perl/APKBUILD
+++ b/main/perl/APKBUILD
@@ -3,7 +3,7 @@
 # Contributor: Valery Kartel <valery.kartel@gmail.com>
 pkgname=perl
 pkgver=5.24.1
-pkgrel=1
+pkgrel=2
 pkgdesc="Larry Wall's Practical Extraction and Report Language"
 url="http://www.perl.org/"
 arch="all"
@@ -92,10 +92,15 @@ dev() {
 	mkdir -p "$subpkgdir"/usr/bin "$subpkgdir"/$_archlib "$subpkgdir"/$_privlib
 	mv "$pkgdir"/$_archlib/Devel "$subpkgdir"/$_archlib/ || return 1
 	mv "$pkgdir"/$_privlib/Encode "$subpkgdir"/$_privlib/ || return 1
+#
+# Encode: enc2xs
+# Module-Corelist: corelist
+# Perldoc: perldoc
+# podlators: pod2man pod2txt
+# 
 	local file
-	for file in c2ph corelist enc2xs instmodsh h2ph h2xs libnetcfg perldoc \
-		perlivp perlthanks pl2pm pod2html pod2man pod2text pod2usage \
-		podchecker podselect xsubpp $pkgname$pkgver
+	for file in c2ph instmodsh h2ph h2xs libnetcfg perlivp perlthanks \
+		pl2pm pod2html pod2usage podchecker podselect xsubpp $pkgname$pkgver
 	do
 		mv "$pkgdir"/usr/bin/$file "$subpkgdir"/usr/bin/ || return 1
 	done
@@ -109,6 +114,15 @@ utils() {
 	pkgdesc="$pkgdesc (misc utilities)"
 	depends="$pkgname"
 	mkdir -p "$subpkgdir"/usr/bin
+#
+# Archive-Tar: ptar ptardiff ptargrep
+# CPAN: cpan
+# Encode: encquess piconv
+# Digest-SHA-PurePerl: shasum
+# IO-Compress: zipdetails
+# JSON-PP: json_pp
+# Test-Harness: prove
+#
 	local file
 	for file in cpan encguess json_pp piconv ptar ptardiff ptargrep shasum \
 		splain zipdetails prove
-- 
2.11.0



---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---
Sören Tempel
Details
Message ID
<20170213125844.GA19524@francium>
In-Reply-To
<20170213080258.28519-1-valery.kartel@gmail.com> (view parent)
Sender timestamp
1486990724
DKIM signature
missing
Download raw message
Thanks for providing a patch that quickly.

On 13.02.17, Valery Kartel wrote:
>       local file
> -     for file in c2ph corelist enc2xs instmodsh h2ph h2xs libnetcfg
> perldoc \
> -             perlivp perlthanks pl2pm pod2html pod2man pod2text
> pod2usage \
> -             podchecker podselect xsubpp $pkgname$pkgver
> +     for file in c2ph instmodsh h2ph h2xs libnetcfg perlivp
> perlthanks \
> +             pl2pm pod2html pod2usage podchecker podselect xsubpp
> $pkgname$pkgver
>       do
>               mv "$pkgdir"/usr/bin/$file "$subpkgdir"/usr/bin/ ||
>               return 1
>       done

What about the other pod* scripts? pod2html, pod2usage, ...
Shouldn't they be moved back to the origin package as well?

Sören.


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---
Natanael Copa
Details
Message ID
<20170227182003.53b24e1d@ncopa-desktop.copa.dup.pw>
In-Reply-To
<20170213125844.GA19524@francium> (view parent)
Sender timestamp
1488216003
DKIM signature
missing
Download raw message
On Mon, 13 Feb 2017 13:58:44 +0100
Sören Tempel <soeren@soeren-tempel.net> wrote:

> Thanks for providing a patch that quickly.
> 
> On 13.02.17, Valery Kartel wrote:
> >       local file
> > -     for file in c2ph corelist enc2xs instmodsh h2ph h2xs libnetcfg
> > perldoc \
> > -             perlivp perlthanks pl2pm pod2html pod2man pod2text
> > pod2usage \
> > -             podchecker podselect xsubpp $pkgname$pkgver
> > +     for file in c2ph instmodsh h2ph h2xs libnetcfg perlivp
> > perlthanks \
> > +             pl2pm pod2html pod2usage podchecker podselect xsubpp
> > $pkgname$pkgver
> >       do
> >               mv "$pkgdir"/usr/bin/$file "$subpkgdir"/usr/bin/ ||
> >               return 1
> >       done  
> 
> What about the other pod* scripts? pod2html, pod2usage, ...
> Shouldn't they be moved back to the origin package as well?

I just got bitten by this for xen.

Where do we want to have pod* scripts?

Should we fix the APKBUILDs to depend on perl-dev to be able to
generate manual pages with pod2man?

Should we have a separate pod* package?

Should we ship those tools with 'perl' like we did earlier?

The commit log does not explain *why* those changes was made in the
first place so I am afraid of just reverting.

Valery, what problem did you try to solve by moving pod* scripts to
-dev?

It would also be great if you could also explain *why* we need
to restore the current compatibility in the commit message for the
"main/perl: restore the current compatibility" patch.

Thanks!

-nc


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---
Sören Tempel
Details
Message ID
<20170228192501.GA27950@francium>
In-Reply-To
<20170227182003.53b24e1d@ncopa-desktop.copa.dup.pw> (view parent)
Sender timestamp
1488309901
DKIM signature
missing
Download raw message
On 27.02.17, Natanael Copa wrote:
> Where do we want to have pod* scripts?
> 
> Should we fix the APKBUILDs to depend on perl-dev to be able to
> generate manual pages with pod2man?

We discussed this a bit on the IRC channel and came to the conclusion
that it is actually not that easy to find all APKBUILDs which need
pod2man. So in case we decide to go with this option we should find a
way to reliable find all APKBUILDs that need to be fixed.

On 27.02.17, Natanael Copa wrote:
> Should we have a separate pod* package?

Why would it be necessary to have such a subpackage. I don't think that
we need to fragment the perl package any further.

On 27.02.17, Natanael Copa wrote:
> Should we ship those tools with 'perl' like we did earlier?

I don't see any reason why we shouldn't do that. Unless there is one we
should probably just revert the commit ASAP before more packages get
rebuild without pod2man and thus end up with broken man pages.

Sören.


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---