X-Original-To: alpine-aports@lists.alpinelinux.org Received: from newmail.tetrasec.net (unknown [172.21.74.12]) by lists.alpinelinux.org (Postfix) with ESMTP id C6DC15C43C0 for ; Fri, 24 Feb 2017 15:48:45 +0000 (GMT) Received: from ncopa-desktop.copa.dup.pw (15.63.200.37.customer.cdi.no [37.200.63.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: n@tanael.org) by newmail.tetrasec.net (Postfix) with ESMTPSA id D01535A113E; Fri, 24 Feb 2017 15:48:44 +0000 (GMT) Date: Fri, 24 Feb 2017 16:48:39 +0100 From: Natanael Copa To: Valery Kartel Cc: alpine-aports@lists.alpinelinux.org Subject: Re: [alpine-aports] [PATCH] testing/rspamd: upgrade to 1.4.4 Message-ID: <20170224164839.47bce33d@ncopa-desktop.copa.dup.pw> In-Reply-To: <20170224143718.22639-1-valery.kartel@gmail.com> References: <20170224143718.22639-1-valery.kartel@gmail.com> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.28; x86_64-alpine-linux-musl) X-Mailinglist: alpine-aports Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 24 Feb 2017 16:37:18 +0200 Valery Kartel wrote: > fixes in init script > --- > testing/rspamd/APKBUILD | 18 +++--------------- > testing/rspamd/rspamd.initd | 10 ++++------ > 2 files changed, 7 insertions(+), 21 deletions(-) > ... > diff --git a/testing/rspamd/rspamd.initd b/testing/rspamd/rspamd.initd > index 93148ccb4b..b0eb9b057a 100644 > --- a/testing/rspamd/rspamd.initd > +++ b/testing/rspamd/rspamd.initd > @@ -18,20 +18,18 @@ depend() { > } > > start_pre() { > - ebegin > - checkpath --directory --mode 750 --owner $user:$group ${pidfile%/*} > + [ "$RC_CMD" = "start" ] && checkpath -d -m 750 -o $user:$group ${pidfile%/*} > $command $command_args -t >/dev/null 2>>${startuplog:-/dev/null} > - eend $? > } > > reload() { > - ebegin "Reloading ${SVCNAME}" > - start-stop-daemon --signal HUP --pidfile $pidfile > + ebegin "Reloading $RC_SVCNAME config" > + start_pre && start-stop-daemon --signal HUP --pidfile $pidfile > eend $? > } > > reopen() { > - ebegin "Reopening ${SVCNAME} log files" > + ebegin "Reopening $RC_SVCNAME log files" > start-stop-daemon --signal USR1 --pidfile $pidfile > eend $? > } I would have prefered: checkconfig() { $command $command_args -t >/dev/null 2>>${startuplog:-/dev/null} } start_pre() { checkpath --directory --mode 750 --owner $user:$group ${pidfile%/*} checkconfig } reload() { ebegin "Reloading $RC_SVCNAME config" checkconfig && start-stop-daemon --signal HUP --pidfile $pidfile eend $? } -nc --- Unsubscribe: alpine-aports+unsubscribe@lists.alpinelinux.org Help: alpine-aports+help@lists.alpinelinux.org ---