X-Original-To: alpine-aports@lists.alpinelinux.org
Received: from mx1.tetrasec.net (mx1.tetrasec.net [74.117.190.25])
	by lists.alpinelinux.org (Postfix) with ESMTP id 3C43A5C4BBF
	for <alpine-aports@lists.alpinelinux.org>; Wed, 14 Jun 2017 13:27:17 +0000 (GMT)
Received: from mx1.tetrasec.net (mail.local [127.0.0.1])
	by mx1.tetrasec.net (Postfix) with ESMTP id AFE629E2016;
	Wed, 14 Jun 2017 13:27:16 +0000 (GMT)
Received: from ncopa-desktop.copa.dup.pw (15.63.200.37.customer.cdi.no [37.200.63.15])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	(Authenticated sender: n@tanael.org)
	by mx1.tetrasec.net (Postfix) with ESMTPSA id CE5599E034C;
	Wed, 14 Jun 2017 13:27:15 +0000 (GMT)
Date: Wed, 14 Jun 2017 15:27:10 +0200
From: Natanael Copa <ncopa@alpinelinux.org>
To: =?ISO-8859-1?B?U/ZyZW4=?= Tempel <soeren@soeren-tempel.net>
Cc: alpine-aports@lists.alpinelinux.org
Subject: Re: [alpine-aports] [PATCH] main/mkinitfs: backport cryptdiscards
 patch
Message-ID: <20170614152710.4f52282a@ncopa-desktop.copa.dup.pw>
In-Reply-To: <20170612105504.GA22141@francium>
References: <20170610100553.3112-1-soeren+git@soeren-tempel.net>
	<20170612113737.0d96dd0a@ncopa-desktop.copa.dup.pw>
	<20170612105504.GA22141@francium>
X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-alpine-linux-musl)
X-Mailinglist: alpine-aports
Precedence: list
List-Id: Alpine Development <alpine-aports.lists.alpinelinux.org>
List-Unsubscribe: 
	<mailto:alpine-aports+unsubscribe@lists.alpinelinux.org?subject=unsubscribe>
List-Post: <mailto:alpine-aports@lists.alpinelinux.org>
List-Help: <mailto:alpine-aports+help@lists.alpinelinux.org?subject=help>
List-Subscribe: 
	<mailto:alpine-aports+subscribe@lists.alpinelinux.org?subject=subscribe>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On Mon, 12 Jun 2017 12:55:04 +0200
S=F6ren Tempel <soeren@soeren-tempel.net> wrote:

> On 12.06.17, Natanael Copa wrote:
> > Does other distros have similar options? If so do they use
> > "cryptdiscards" as bootoption too, or something else? =20
>=20
> Yes, other distros have similar options. According to the Arch Linux
> wiki[1] all systemd based initrds use `rd.luks.options=3Ddiscard` for
> enabling this.
>=20
> Cheers,
> S=F6ren
>=20
> [1]: https://wiki.archlinux.org/index.php/Dm-crypt/Specialties#Discard.2F=
TRIM_support_for_solid_state_drives_.28SSD.29

Arch also has:

  cryptdevice=3D/dev/sdaX:root:allow-discards

and apparently they also have cryptkey=3D... for detached header.

Gentoo[1] does:
  root_trim=3Dyes


Debian/ubuntu stores that option in /etc/crypttab which needs to be include=
d in initramfs.

We currently have:

cryptroot cryptdm cryptheader cryptoffset

and now we add cryptdiscard

I kind of like the old Arch Linux way better:

  cryptdevice=3D$cryptroot:$cryptdm:$cryptdiscard

and for detached header:

  cryptkey=3D$cryptheader:$cryptoffset:$size


What do you think? Should we go for:

  cryptroot=3D$device cryptdm=3D$dmname cyptdiscards=3Dyes cryptheader=3D$h=
eader cryptoffset=3D$offset

or should we do:

  cryptdevice=3D$device:$dmname:allow-discards cryptkey=3D$header:$offset

-nc

[1]: https://wiki.gentoo.org/wiki/Dm-crypt_full_disk_encryption#Genkernel.2=
FGenkernel-next


>=20
>=20
> ---
> Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
> Help:         alpine-aports+help@lists.alpinelinux.org
> ---
>=20



---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---