Subject: [alpine-aports] [PATCH] main/bc: Added readline support

From: Marian Buschsieweke <[email-masked]>
Date: Mon, 17 Jul 2017 20:57:36 +0200

The makedepens `readline-dev` suggests that readline support was intented.
However, option `--with-readline` needs also be passed to compile bc with
readline support. In addtion, I added readline as dependency.
---
 main/bc/APKBUILD | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/main/bc/APKBUILD b/main/bc/APKBUILD
index bc496fa1f4..8dc270b5e6 100644
--- a/main/bc/APKBUILD
+++ b/main/bc/APKBUILD
@@ -7,7 +7,7 @@ pkgdesc="An arbitrary precision numeric processing language (calculator)"
 url="http://www.gnu.org/software/bc/bc.html"
 arch="all"
 license="GPL2+"
-depends=""
+depends="readline"
 makedepends="flex bison readline-dev texinfo"
 subpackages="$pkgname-doc"
 source="ftp://alpha.gnu.org/gnu/bc/bc-$pkgver.tar.bz2
@@ -24,7 +24,8 @@ build() {
 		--prefix=/usr \
 		--sysconfdir=/etc \
 		--mandir=/usr/share/man \
-		--infodir=/usr/share/info
+		--infodir=/usr/share/info \
+		--with-readline
 	make
 }
 
-- 
2.13.2

---
Unsubscribe:  [email-masked]
Help:         [email-masked]
---

---

From: Timo Teras <[email-masked]>
Date: Tue, 18 Jul 2017 10:21:48 +0300

Hi,

On Mon, 17 Jul 2017 20:57:36 +0200
Marian Buschsieweke <[email-masked]> wrote:

> The makedepens `readline-dev` suggests that readline support was
> intented. However, option `--with-readline` needs also be passed to
> compile bc with readline support. In addtion, I added readline as
> dependency. ---

Yes, seems the configure behaviour has changed. Now it gave warning
that libreadline works only with flex and did not automatically enable
it.

> @@ -7,7 +7,7 @@ pkgdesc="An arbitrary precision numeric processing
> language (calculator)" url="http://www.gnu.org/software/bc/bc.html"
>  arch="all"
>  license="GPL2+"
> -depends=""
> +depends="readline"

This is not needed. abuild picks up .so dependencies automatically.

OTOH, pkgrel needs to be incremented.

I made these two changes, and pushed.

Thanks!

---