Sender: =?UTF-8?Q?Timo_Ter=C3=A4s?= <timo.teras@gmail.com>
Date: Tue, 18 Jul 2017 10:21:48 +0300
From: Timo Teras <timo.teras@iki.fi>
To: Marian Buschsieweke <marian.buschsieweke@ovgu.de>
Cc: alpine-aports@lists.alpinelinux.org
Subject: Re: [alpine-aports] [PATCH] main/bc: Added readline support
Message-ID: <20170718102106.44e12b98@vostro>
In-Reply-To: <20170717185736.6556-1-marian.buschsieweke@ovgu.de>
References: <20170717185736.6556-1-marian.buschsieweke@ovgu.de>
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Hi,

On Mon, 17 Jul 2017 20:57:36 +0200
Marian Buschsieweke <marian.buschsieweke@ovgu.de> wrote:

> The makedepens `readline-dev` suggests that readline support was
> intented. However, option `--with-readline` needs also be passed to
> compile bc with readline support. In addtion, I added readline as
> dependency. ---

Yes, seems the configure behaviour has changed. Now it gave warning
that libreadline works only with flex and did not automatically enable
it.

>  main/bc/APKBUILD | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/main/bc/APKBUILD b/main/bc/APKBUILD
> index bc496fa1f4..8dc270b5e6 100644
> --- a/main/bc/APKBUILD
> +++ b/main/bc/APKBUILD
> @@ -7,7 +7,7 @@ pkgdesc="An arbitrary precision numeric processing
> language (calculator)" url="http://www.gnu.org/software/bc/bc.html"
>  arch="all"
>  license="GPL2+"
> -depends=""
> +depends="readline"

This is not needed. abuild picks up .so dependencies automatically.

OTOH, pkgrel needs to be incremented.

I made these two changes, and pushed.

Thanks!



---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---