X-Original-To: alpine-aports@lists.alpinelinux.org Received: from mx1.tetrasec.net (mx1.tetrasec.net [74.117.190.25]) by lists.alpinelinux.org (Postfix) with ESMTP id 58A015C4B3B for ; Thu, 3 Aug 2017 11:52:12 +0000 (GMT) Received: from mx1.tetrasec.net (mail.local [127.0.0.1]) by mx1.tetrasec.net (Postfix) with ESMTP id 178E89E26B5; Thu, 3 Aug 2017 11:52:12 +0000 (GMT) Received: from ncopa-desktop.copa.dup.pw (15.63.200.37.customer.cdi.no [37.200.63.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: n@tanael.org) by mx1.tetrasec.net (Postfix) with ESMTPSA id 41AEB9E0357; Thu, 3 Aug 2017 11:52:10 +0000 (GMT) Date: Thu, 3 Aug 2017 13:52:04 +0200 From: Natanael Copa To: Marian Buschsieweke Cc: alpine-aports@lists.alpinelinux.org Subject: Re: [alpine-aports] [PATCH] new aport: testing/micropython Message-ID: <20170803135204.67a821db@ncopa-desktop.copa.dup.pw> In-Reply-To: <20170802072403.2885-1-marian.buschsieweke@ovgu.de> References: <20170802072403.2885-1-marian.buschsieweke@ovgu.de> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-alpine-linux-musl) X-Mailinglist: alpine-aports Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 2 Aug 2017 09:24:03 +0200 Marian Buschsieweke wrote: > A lean and efficient Python implementation for MCUs and constrained systems > http://www.micropython.org/ > --- > testing/micropython/0000-unix-mpconfigport.patch | 22 ++++++++++++ > testing/micropython/APKBUILD | 44 ++++++++++++++++++++++++ > 2 files changed, 66 insertions(+) > create mode 100644 testing/micropython/0000-unix-mpconfigport.patch > create mode 100644 testing/micropython/APKBUILD Thanks you for this. Please see comments below: > + > +prepare() { > + cd "${srcdir}" > + for i in $source; do > + case $i in > + *.patch) msg $i; patch -p1 -i "$srcdir"/$i || return 1;; > + esac > + done > +} You don't need the prepare() function. Recent abuild will do that automatically for you. > + > +build() { > + cd "$builddir" > + unset CFLAGS Why is unsetting CFLAGS needed? > + make > +} > + > +check() { > + cd "$builddir" > + make test > +} > + > +package() { > + cd "$builddir" > + mkdir -p "${pkgdir}/usr/bin" > + install -m755 micropython "${pkgdir}/usr/bin/micropython" > +} > + build fails due to missing pyhon: Generating build/frozen.c env: can't execute 'python': No such file or directory When I add python2 to makedepends it fails during tests: ... skip unix/extra_coverage.py FAIL unix/ffi_callback.py pass unix/ffi_float.py pass unix/ffi_float2.py 597 tests performed (18223 individual testcases) 596 tests passed 40 tests skipped: builtin_help class_delattr_setattr cmd_parsetree btree1 framebuf1 framebuf16 framebuf4 uhashlib_sha1 urandom_extra ussl_basic vfs_basic vfs_fa t_fileio1 vfs_fat_fileio2 vfs_fat_more vfs_fat_oldproto vfs_fat_ramdisk buffered_writer native_closure native_const_intbig native_misc schedule viper_addr viper _args viper_binop_arith viper_binop_comp viper_binop_comp_imm viper_binop_multi_comp viper_cond viper_error viper_import viper_misc viper_misc_intbig viper_ptr1 6_load viper_ptr16_store viper_ptr32_load viper_ptr32_store viper_ptr8_load viper_ptr8_store viper_subscr extra_coverage 1 tests failed: ffi_callback make: *** [Makefile:192: test] Error 1 > +sha512sums="bc0eeb1e6d821034b7157613f2d421df304f2959e9fd62d2886641eba8d74575787861c9ff46fc3bcb9c14c6ad1f698043231801207f946af9b5d302bb253c63 micropython-1.9.1.tar.gz > +926515a76dc856192de79a7c35c390bd533a38a2c163812ce5a3739280ca33881791f3d199922edb2e577ec9ac16265dc4891ad96f6c6eb4e7cf9d5ae8044a32 0000-unix-mpconfigport.patch" --- Unsubscribe: alpine-aports+unsubscribe@lists.alpinelinux.org Help: alpine-aports+help@lists.alpinelinux.org ---