X-Original-To: alpine-aports@lists.alpinelinux.org Received: from mx1.tetrasec.net (mx1.tetrasec.net [74.117.190.25]) by lists.alpinelinux.org (Postfix) with ESMTP id 5917A5C4C36 for ; Thu, 3 Aug 2017 13:31:22 +0000 (GMT) Received: from mx1.tetrasec.net (mail.local [127.0.0.1]) by mx1.tetrasec.net (Postfix) with ESMTP id 2AB119E26C8; Thu, 3 Aug 2017 13:31:22 +0000 (GMT) Received: from ncopa-desktop.copa.dup.pw (15.63.200.37.customer.cdi.no [37.200.63.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: n@tanael.org) by mx1.tetrasec.net (Postfix) with ESMTPSA id 4E9569E0120; Thu, 3 Aug 2017 13:31:19 +0000 (GMT) Date: Thu, 3 Aug 2017 15:31:14 +0200 From: Natanael Copa To: Oleg Omelyusik Cc: alpine-aports@lists.alpinelinux.org, Shiz Subject: Re: [alpine-aports] [PATCH] main/busybox: fix timezone adjustment in syslogd Message-ID: <20170803153114.0a745ebb@ncopa-desktop.copa.dup.pw> In-Reply-To: References: <20170721222342.22201-1-oleg.omelyusik@gmail.com> <20170724144937.1a2c8ca7@ncopa-desktop.copa.dup.pw> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-alpine-linux-musl) X-Mailinglist: alpine-aports Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 24 Jul 2017 16:06:22 +0300 Oleg Omelyusik wrote: > > On 24 July 2017 at 15:49, Natanael Copa wrote: > > On Sat, 22 Jul 2017 01:23:42 +0300 > > Oleg Omelyusik wrote: > > > >> --- > >> ...gd-fix-timezone-adjustment-implementation.patch | 47 ++++++++++++++++++++++ > >> main/busybox/APKBUILD | 2 + > >> 2 files changed, 49 insertions(+) > >> create mode 100644 main/busybox/0012-syslogd-fix-timezone-adjustment-implementation.patch > >> > >> diff --git a/main/busybox/0012-syslogd-fix-timezone-adjustment-implementation.patch b/main/busybox/0012-syslogd-fix-timezone-adjustment-implementation.patch > >> new file mode 100644 > >> index 0000000000..f276bc3e57 > >> --- /dev/null > >> +++ b/main/busybox/0012-syslogd-fix-timezone-adjustment-implementation.patch > >> @@ -0,0 +1,47 @@ > >> +From b09a292755943b3881aa3525c906989929c19fc8 Mon Sep 17 00:00:00 2001 > >> +From: Oleg Omelyusik > >> +Date: Fri, 21 Jul 2017 16:29:55 +0300 > >> +Subject: [PATCH] syslogd: fix timezone adjustment implementation > >> + > >> +strptime() does not set year value which is needed for mktime(). > >> +Also need to take into account year value when operating with timestamps > >> +to prevent invalid convertions for leap years (e.g. Feb 28 23:00:00 UTC to GMT+2). > > > > Was this patch sent upstream? > > No it wasn't, since timezone adjustment is Alpine specific feature. > This is about '-Z' option added to syslogd (commit > 318c497f003be1645152235d1b08005f7dfde3ee in aports repo). > I've also found related open bug in your tracker and updated it: > https://bugs.alpinelinux.org/issues/3694 Shiz: Can you please have a look at this? -nc --- Unsubscribe: alpine-aports+unsubscribe@lists.alpinelinux.org Help: alpine-aports+help@lists.alpinelinux.org ---