X-Original-To: alpine-aports@lists.alpinelinux.org
Received: from magnesium.8pit.net (magnesium.8pit.net [45.76.88.171])
	by lists.alpinelinux.org (Postfix) with ESMTP id 8A4FD5C4C9A
	for <alpine-aports@lists.alpinelinux.org>; Sat, 19 Aug 2017 20:34:05 +0000 (GMT)
Received: from localhost (p54BA3835.dip0.t-ipconnect.de [84.186.56.53])
	by magnesium.8pit.net (OpenSMTPD) with ESMTPSA id e6adf53e (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO);
	Sat, 19 Aug 2017 22:34:02 +0200 (CEST)
Date: Sat, 19 Aug 2017 22:33:56 +0200
From: =?iso-8859-1?Q?S=F6ren?= Tempel <soeren@soeren-tempel.net>
To: alpine-aports@lists.alpinelinux.org
Cc: marian.buschsieweke@ovgu.de
Subject: Re: [alpine-aports] [PATCH] testing/git-lfs: new aport
Message-ID: <20170819203356.nebhfnretohfeqtt@francium>
References: <20170816165357.2714-1-marian.buschsieweke@ovgu.de>
X-Mailinglist: alpine-aports
Precedence: list
List-Id: Alpine Development <alpine-aports.lists.alpinelinux.org>
List-Unsubscribe: 
	<mailto:alpine-aports+unsubscribe@lists.alpinelinux.org?subject=unsubscribe>
List-Post: <mailto:alpine-aports@lists.alpinelinux.org>
List-Help: <mailto:alpine-aports+help@lists.alpinelinux.org?subject=help>
List-Subscribe: 
	<mailto:alpine-aports+subscribe@lists.alpinelinux.org?subject=subscribe>
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20170816165357.2714-1-marian.buschsieweke@ovgu.de>

There already is an aport for git-lfs in unmaintained/ I would suggest
moving it from unmaintained/ to testing/ and updating it accordingly.

Besides git-lfs does in fact have a testsuite [0]. Please don't use
`options=3D!check` and instead add a check() function invoking the test
suite.

[0]: https://github.com/git-lfs/git-lfs/tree/master/test


On 16.08.17, Marian Buschsieweke wrote:
> An open source Git extension for versioning large files
> https://git-lfs.github.com/
> ---
>  testing/git-lfs/APKBUILD | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
>  create mode 100644 testing/git-lfs/APKBUILD
>=20
> diff --git a/testing/git-lfs/APKBUILD b/testing/git-lfs/APKBUILD
> new file mode 100644
> index 0000000000..e90784d252
> --- /dev/null
> +++ b/testing/git-lfs/APKBUILD
> @@ -0,0 +1,27 @@
> +# Contributor: Marian Buschsieweke <marian.buschsieweke@ovgu.de>
> +# Maintainer: Marian Buschsieweke <marian.buschsieweke@ovgu.de>
> +pkgname=3Dgit-lfs
> +pkgver=3D2.2.1
> +pkgrel=3D0
> +pkgdesc=3D"An open source Git extension for versioning large files"
> +url=3D"https://git-lfs.github.com/"
> +arch=3D"all"
> +license=3D"MIT"
> +depends=3D"git"
> +makedepends=3D"go"
> +subpackages=3D""
> +source=3D"$pkgname-$pkgver.tar.gz::https://github.com/${pkgname}/${pkgna=
me}/archive/v${pkgver}.tar.gz"
> +options=3D"!check"
> +
> +build() {
> +	cd "$builddir"
> +	GOPATH=3D"${PWD}" go get -v -d
> +	GOPATH=3D"${PWD}" go run script/*.go -cmd build
> +}
> +
> +package() {
> +	cd "$builddir"
> +	install -Dm755 "bin/${pkgname}" "${pkgdir}/usr/bin/${pkgname}"
> +}
> +
> +sha512sums=3D"8e1edd588916e6a09c0fe84bdcd80b8773f3874554f941c65819bbb29c=
dce4846de6408dbb34b33e420d9bc768f6cd07c2dbb0979d243c98f25a32d4fc69dea4  git=
-lfs-2.2.1.tar.gz"
> --=20
> 2.14.1
>=20
>=20
>=20
> ---
> Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
> Help:         alpine-aports+help@lists.alpinelinux.org
> ---
>=20

S=F6ren.


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---