Sender: =?UTF-8?Q?Timo_Ter=C3=A4s?= <timo.teras@gmail.com>
Date: Mon, 28 Aug 2017 11:06:26 +0300
From: Timo Teras <timo.teras@iki.fi>
To: Marian Buschsieweke <marian.buschsieweke@ovgu.de>
Cc: alpine-aports@lists.alpinelinux.org
Subject: Re: [alpine-aports] testing/prosody-mod-auth-ldap: New aport
Message-ID: <20170828110626.0861f0f6@vostro.util.wtbts.net>
In-Reply-To: <20170817173149.25059-1-marian.buschsieweke@ovgu.de>
References: <20170817173149.25059-1-marian.buschsieweke@ovgu.de>
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

Hi,

On Thu, 17 Aug 2017 19:31:49 +0200
Marian Buschsieweke <marian.buschsieweke@ovgu.de> wrote:

> A Prosody authentication plugin which uses LDAP as the backend
> https://modules.prosody.im/mod_auth_ldap.html
> ---
>  testing/prosody-mod-auth-ldap/APKBUILD | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
>  create mode 100644 testing/prosody-mod-auth-ldap/APKBUILD
> 
> diff --git a/testing/prosody-mod-auth-ldap/APKBUILD
> b/testing/prosody-mod-auth-ldap/APKBUILD new file mode 100644
> index 0000000000..fd0cb3f232
> --- /dev/null
> +++ b/testing/prosody-mod-auth-ldap/APKBUILD
> @@ -0,0 +1,22 @@
> +# Contributor: Marian <marian.buschsieweke@ovgu.de>
> +# Maintainer: Marian <marian.buschsieweke@ovgu.de>
> +pkgname=prosody-mod-auth-ldap
> +_prosody_mod_name=auth_ldap
> +pkgver=20170817
> +pkgrel=0
> +pkgdesc="A Prosody authentication plugin which uses LDAP as the
> backend" +url="https://modules.prosody.im/mod_auth_ldap.html"
> +arch="noarch"
> +
> +license="MIT"
> +depends="prosody lua5.1-ldap"
> +makedepends=""
> +subpackages=""
> +source="https://hg.prosody.im/prosody-modules/raw-file/tip/mod_${_prosody_mod_name}/mod_${_prosody_mod_name}.lua"

This refers to 'tip' which basically means 'latest version'. Please use
versioned links, as otherwise the checksums don't match and we cannot
produce consistent builds.

Same applies for the other prosody modules commits.

Thinking more, I'm wondering would it make sense to have one source
package 'prososdy-modules' that packages all the modules and is split
to these different modules then...

I'm marking all the prosody modules as 'changes requested'.

Also one of the modules was incorporated to prosody 0.10. Would it make
sense to first upgrade prosody (or is it still unreleased/unstable
version?).

Timo


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---