X-Original-To: alpine-aports@lists.alpinelinux.org Received: from magnesium.8pit.net (magnesium.8pit.net [45.76.88.171]) by lists.alpinelinux.org (Postfix) with ESMTP id 82DE55C3EB3 for ; Wed, 1 Nov 2017 21:30:03 +0000 (GMT) Received: from localhost (p200300C60BC2BA0008DC1E3F5CC0B97E.dip0.t-ipconnect.de [IPv6:2003:c6:bc2:ba00:8dc:1e3f:5cc0:b97e]) by magnesium.8pit.net (OpenSMTPD) with ESMTPSA id 3ffc230d (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO); Wed, 1 Nov 2017 22:30:00 +0100 (CET) Date: Wed, 1 Nov 2017 22:29:59 +0100 From: =?iso-8859-1?Q?S=F6ren?= Tempel To: =?iso-8859-1?B?Q+Fn?= Cc: alpine-aports@lists.alpinelinux.org Subject: Re: [alpine-aports] [PATCH] main/dzen: modernise APKBUILD Message-ID: <20171101212959.GA26119@francium> References: <20171101191514.2514-1-ca6c@bitmessage.ch> X-Mailinglist: alpine-aports Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <20171101191514.2514-1-ca6c@bitmessage.ch> Hi C=E1g, On 01.11.17, C=E1g wrote: > @@ -21,14 +21,14 @@ prepare() { > cd "$_builddir" > for i in $source; do > case $i in > - *.patch) msg $i; patch -p1 -i "$srcdir"/$i || return 1;; > + *.patch) msg $i; patch -p1 -i "$srcdir"/$i;; > esac > done > } Since you already started modernizing this aport I would suggest removing that function entirely since this is what is nowadays done by default_prepare [1]. In order to utilize that function `_builddir` needs to be renamed to `builddir`. It would be nice if you could also apply this change for main/acpi. [1]: https://git.alpinelinux.org/cgit/abuild/tree/abuild.in?h=3Dv3.1.0#n595 Cheers, S=F6ren --- Unsubscribe: alpine-aports+unsubscribe@lists.alpinelinux.org Help: alpine-aports+help@lists.alpinelinux.org ---