Patches for aports can be sent to this list

1

[alpine-aports] [PATCH] testing/zile: new aport

Jose Maria Garcia
Details
Message ID
<20171117193741.8370-1-josemaria.alkala@gmail.com>
Sender timestamp
1510947461
DKIM signature
missing
Download raw message
Patch: +68 -0
https://www.gnu.org/software/zile/
GNU Zile is a text editor development kit.
---
 testing/zile/APKBUILD  | 34 ++++++++++++++++++++++++++++++++++
 testing/zile/APKBUILD~ | 34 ++++++++++++++++++++++++++++++++++
 2 files changed, 68 insertions(+)
 create mode 100644 testing/zile/APKBUILD
 create mode 100644 testing/zile/APKBUILD~

diff --git a/testing/zile/APKBUILD b/testing/zile/APKBUILD
new file mode 100644
index 0000000000..0cc9ec7071
--- /dev/null
+++ b/testing/zile/APKBUILD
@@ -0,0 +1,34 @@
+# Contributor: Jose Maria Garcia <josemaria.alkala@gmail.com>
+# Maintainer: Jose Maria Garcia <josemaria.alkala@gmail.com>
+pkgname=zile
+pkgver=2.4.14
+pkgrel=1
+pkgdesc="GNU Zile is a text editor development kit."
+url="https://www.gnu.org/software/zile"
+arch="all"
+license="GPL3"
+depends="ncurses gc"
+makedepends="ncurses-dev gc-dev perl help2man"
+install=""
+subpackages="${pkgname}-doc"
+source="http://ftp.gnu.org/gnu/zile/${pkgname}-${pkgver}.tar.gz"
+builddir="$srcdir/${pkgname}-${pkgver}"
+
+build() {
+        cd "$builddir"
+        ./configure \
+                --prefix=/usr \
+                --sysconfdir=/etc \
+                --mandir=/usr/share/man \
+                --localstatedir=/var
+        make
+}
+
+package() {
+        cd "$builddir"
+        make DESTDIR="$pkgdir" install
+        rm -f "$pkgdir"/usr/lib/charset.alias
+}
+
+sha512sums="0dea56fd13a82015ec73de3139a4b2c27ad4c001ed535f1bae557ee49f9d8a188610a08160998d0a36b95fec42b46a019fd43634ef6502ebd27e162164de98cc  zile-2.4.14.tar.gz"
+
diff --git a/testing/zile/APKBUILD~ b/testing/zile/APKBUILD~
new file mode 100644
index 0000000000..519922781c
--- /dev/null
+++ b/testing/zile/APKBUILD~
@@ -0,0 +1,34 @@
+# Contributor: Jose Maria Garcia <josemaria.alkala@gmail.com>
+# Maintainer:
+pkgname=zile
+pkgver=2.4.14
+pkgrel=0
+pkgdesc="GNU Zile is a text editor development kit."
+url="https://www.gnu.org/software/zile"
+arch="all"
+license="GPL3"
+depends="ncurses gc"
+makedepends="ncurses-dev gc-dev perl help2man"
+install=""
+subpackages="${pkgname}-doc"
+source="http://ftp.gnu.org/gnu/zile/${pkgname}-${pkgver}.tar.gz"
+builddir="$srcdir/${pkgname}-${pkgver}"
+
+build() {
+        cd "$builddir"
+        ./configure \
+                --prefix=/usr \
+                --sysconfdir=/etc \
+                --mandir=/usr/share/man \
+                --localstatedir=/var
+        make
+}
+
+package() {
+        cd "$builddir"
+        make DESTDIR="$pkgdir" install
+        rm -f "$pkgdir"/usr/lib/charset.alias
+}
+
+sha512sums="0dea56fd13a82015ec73de3139a4b2c27ad4c001ed535f1bae557ee49f9d8a188610a08160998d0a36b95fec42b46a019fd43634ef6502ebd27e162164de98cc  zile-2.4.14.tar.gz"
+
-- 
2.15.0



---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---
Natanael Copa
Details
Message ID
<20171121160543.41fae14f@ncopa-desktop.copa.dup.pw>
In-Reply-To
<20171117193741.8370-1-josemaria.alkala@gmail.com> (view parent)
Sender timestamp
1511276743
DKIM signature
missing
Download raw message
Hi!

Thank you for contributing!

Please see comments below.

On Fri, 17 Nov 2017 20:37:41 +0100
Jose Maria Garcia <josemaria.alkala@gmail.com> wrote:

> https://www.gnu.org/software/zile/
> GNU Zile is a text editor development kit.
> ---
>  testing/zile/APKBUILD  | 34 ++++++++++++++++++++++++++++++++++
>  testing/zile/APKBUILD~ | 34 ++++++++++++++++++++++++++++++++++
>  2 files changed, 68 insertions(+)
>  create mode 100644 testing/zile/APKBUILD
>  create mode 100644 testing/zile/APKBUILD~
> 
> diff --git a/testing/zile/APKBUILD b/testing/zile/APKBUILD
> new file mode 100644
> index 0000000000..0cc9ec7071
> --- /dev/null
> +++ b/testing/zile/APKBUILD
> @@ -0,0 +1,34 @@
> +# Contributor: Jose Maria Garcia <josemaria.alkala@gmail.com>
> +# Maintainer: Jose Maria Garcia <josemaria.alkala@gmail.com>
> +pkgname=zile
> +pkgver=2.4.14
> +pkgrel=1

We start counting pkgrel from 0 in alpine.

> +pkgdesc="GNU Zile is a text editor development kit."
> +url="https://www.gnu.org/software/zile"
> +arch="all"
> +license="GPL3"
> +depends="ncurses gc"

You don't need add the runtime shared libraries manually to depends.
abuild will detect them for you and keep track in what package keeps
which library.

> +makedepends="ncurses-dev gc-dev perl help2man"
> +install=""
> +subpackages="${pkgname}-doc"
> +source="http://ftp.gnu.org/gnu/zile/${pkgname}-${pkgver}.tar.gz"
> +builddir="$srcdir/${pkgname}-${pkgver}"
> +
> +build() {
> +        cd "$builddir"
> +        ./configure \
> +                --prefix=/usr \
> +                --sysconfdir=/etc \
> +                --mandir=/usr/share/man \
> +                --localstatedir=/var
> +        make
> +}
> +
> +package() {
> +        cd "$builddir"
> +        make DESTDIR="$pkgdir" install
> +        rm -f "$pkgdir"/usr/lib/charset.alias
> +}
> +

Those looks good.
 +sha512sums="0dea56fd13a82015ec73de3139a4b2c27ad4c001ed535f1bae557ee49f9d8a188610a08160998d0a36b95fec42b46a019fd43634ef6502ebd27e162164de98cc  zile-2.4.14.tar.gz"
> +
> diff --git a/testing/zile/APKBUILD~ b/testing/zile/APKBUILD~
> new file mode 100644
> index 0000000000..519922781c
> --- /dev/null
> +++ b/testing/zile/APKBUILD~

I suppose this file should not been included in the commit?

Can you please fix the above issues and resend?

http://wiki.alpinelinux.org/wiki/Creating_patches#Resend_an_updated_patch


Thanks!

-nc


> @@ -0,0 +1,34 @@
> +# Contributor: Jose Maria Garcia <josemaria.alkala@gmail.com>
> +# Maintainer:
> +pkgname=zile
> +pkgver=2.4.14
> +pkgrel=0
> +pkgdesc="GNU Zile is a text editor development kit."
> +url="https://www.gnu.org/software/zile"
> +arch="all"
> +license="GPL3"
> +depends="ncurses gc"
> +makedepends="ncurses-dev gc-dev perl help2man"
> +install=""
> +subpackages="${pkgname}-doc"
> +source="http://ftp.gnu.org/gnu/zile/${pkgname}-${pkgver}.tar.gz"
> +builddir="$srcdir/${pkgname}-${pkgver}"
> +
> +build() {
> +        cd "$builddir"
> +        ./configure \
> +                --prefix=/usr \
> +                --sysconfdir=/etc \
> +                --mandir=/usr/share/man \
> +                --localstatedir=/var
> +        make
> +}
> +
> +package() {
> +        cd "$builddir"
> +        make DESTDIR="$pkgdir" install
> +        rm -f "$pkgdir"/usr/lib/charset.alias
> +}
> +
> +sha512sums="0dea56fd13a82015ec73de3139a4b2c27ad4c001ed535f1bae557ee49f9d8a188610a08160998d0a36b95fec42b46a019fd43634ef6502ebd27e162164de98cc  zile-2.4.14.tar.gz"
> +



---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---