X-Original-To: alpine-aports@lists.alpinelinux.org Received: from mx1.tetrasec.net (mx1.tetrasec.net [74.117.190.25]) by lists.alpinelinux.org (Postfix) with ESMTP id 496AA5C4D6A for ; Mon, 18 Dec 2017 12:49:44 +0000 (GMT) Received: from mx1.tetrasec.net (mail.local [127.0.0.1]) by mx1.tetrasec.net (Postfix) with ESMTP id EAB169E1C27; Mon, 18 Dec 2017 12:49:43 +0000 (GMT) Received: from ncopa-desktop.copa.dup.pw (15.63.200.37.customer.cdi.no [37.200.63.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: n@tanael.org) by mx1.tetrasec.net (Postfix) with ESMTPSA id 4B1D79E03F9; Mon, 18 Dec 2017 12:49:42 +0000 (GMT) Date: Mon, 18 Dec 2017 13:49:36 +0100 From: Natanael Copa To: Bruno d'Arcangeli Cc: alpine-aports@lists.alpinelinux.org Subject: Re: [alpine-aports] testing/ladspa: new aport Message-ID: <20171218134936.7e6f536e@ncopa-desktop.copa.dup.pw> In-Reply-To: <20171209105608.3713-1-bruno@arcangeli.org> References: <20171209105608.3713-1-bruno@arcangeli.org> X-Mailer: Claws Mail 3.15.1-dirty (GTK+ 2.24.31; x86_64-alpine-linux-musl) X-Mailinglist: alpine-aports Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Hi Bruno! Than you for your contribution. Can you please explain what this patch is supposed to fix? -nc On Sat, 9 Dec 2017 11:56:08 +0100 Bruno d'Arcangeli wrote: > --- > testing/ladspa/APKBUILD | 45 +++++++++++----------- > testing/ladspa/fallback-ladspa-path.patch | 8 ++-- > .../ladspa/fix-memleak-in-plugin-scanning.patch | 4 +- > 3 files changed, 28 insertions(+), 29 deletions(-) > > diff --git a/testing/ladspa/APKBUILD b/testing/ladspa/APKBUILD > index 6d2ba1c76c..7417ec8399 100644 > --- a/testing/ladspa/APKBUILD > +++ b/testing/ladspa/APKBUILD > @@ -1,45 +1,44 @@ > -# Contributor: Carlo Landmeter > -# Maintainer: > +# Contributor: Bruno Arcangeli > +# Maintainer: Bruno Arcangeli > pkgname=ladspa > pkgver=1.13 > -pkgrel=0 > -pkgdesc="Linux Audio Developer's Simple Plug-in API, examples and tools" > +pkgrel=1 > +pkgdesc="Linux Audio Developer's Simple Plugin API (LADSPA)" > url="http://www.ladspa.org/" > arch="all" > -license="LGPL2" > +license="LGPL" > depends="" > makedepends="" > install="" > subpackages="$pkgname-dev" > -source="https://github.com/OpenMandrivaAssociation/ladspa/raw/master/ladspa_sdk_1.13.tgz > - fallback-ladspa-path.patch > - fix-memleak-in-plugin-scanning.patch > - " > +source="https://github.com/OpenMandrivaAssociation/ladspa/raw/master/ladspa_sdk_$pkgver.tgz > + fix-memleak-in-plugin-scanning.patch > + fallback-ladspa-path.patch" > builddir="$srcdir/ladspa_sdk/src" > > prepare() { > - default_prepare || return 1 > - sed -i 's/mkdirhier/mkdir -p/' makefile || return 1 > + cd "$builddir" > + patch -Np1 -i "${srcdir}/fix-memleak-in-plugin-scanning.patch" > + patch -Np2 -i "${srcdir}/fallback-ladspa-path.patch" > + sed \ > + -e 's/mkdirhier/mkdir -p/' \ > + -e "s#-O3#${CFLAGS} ${LDFLAGS/,--as-needed/}#" \ > + -e "s/-Wl//g" \ > + -i makefile > } > > build() { > cd "$builddir" > - make targets || return 1 > + make targets > } > > package() { > cd "$builddir" > - make INSTALL_PLUGINS_DIR="$pkgdir/usr/lib/ladspa/" \ > - INSTALL_INCLUDE_DIR="$pkgdir/usr/include/" \ > - INSTALL_BINARY_DIR="$pkgdir/usr/bin/" install || return 1 > + make INSTALL_PLUGINS_DIR="$pkgdir/usr/lib/ladspa/" \ > + INSTALL_INCLUDE_DIR="$pkgdir/usr/include/" \ > + INSTALL_BINARY_DIR="$pkgdir/usr/bin/" install > } > > -md5sums="671be3e1021d0722cadc7fb27054628e ladspa_sdk_1.13.tgz > -d3a0f23f66cd685fe4af419c4f587273 fallback-ladspa-path.patch > -525a958f339d7526562785484b577d00 fix-memleak-in-plugin-scanning.patch" > -sha256sums="b5ed3f4f253a0f6c1b7a1f4b8cf62376ca9f51d999650dd822650c43852d306b ladspa_sdk_1.13.tgz > -4d066b10a10801bc87468ddc4fb1672b2fa9866bd5f3155c71c884296c6345d0 fallback-ladspa-path.patch > -d12f061d2701f0d12f97f750bb6df7c3a9915db5e35a00bd7d1a6342218bcb39 fix-memleak-in-plugin-scanning.patch" > sha512sums="a1dab807fda58e08869d3f519be5fa91c394690eb13006fbe7f20b332548e4676b32b01273f5695bf36c8da72190c07618662a76d50f991b3f05068ac2b346ef ladspa_sdk_1.13.tgz > -00891ac5d1e3ca17cf7d99e7d894b50f9a7df8eea80cd791593cf637bf9f4f7e658d0124c69aa32bb90a14150737a38cb48552c7991f3f2b6674b3634440504a fallback-ladspa-path.patch > -1a96b24a47c2c82f7c2f66e2ee711f0ecbed9b03260562b72ced1bd4c8f0e518d15fc7c15951b95b1999e3dae1723b855fd3431a9795279f8a88ad68900e48e7 fix-memleak-in-plugin-scanning.patch" > +e80a575e6afe42f9d0ac1234a7832a29fb9362c7ab7b2d6b14cc3e6da6a9ba67af886cf09f1c0b78c161205084f705049fb4dc22fe2795efaeb7d94da90dc93e fix-memleak-in-plugin-scanning.patch > +fb634ae45968bc62a3398f56b239088655a878cc19915c377669fcf710ce6bf6457485da88db0eaab4d0c674aa611d8e1d91d5d7d138f4a932b0f263706ba71a fallback-ladspa-path.patch" > diff --git a/testing/ladspa/fallback-ladspa-path.patch b/testing/ladspa/fallback-ladspa-path.patch > index a0a3c43a36..7743bf4b43 100644 > --- a/testing/ladspa/fallback-ladspa-path.patch > +++ b/testing/ladspa/fallback-ladspa-path.patch > @@ -1,6 +1,6 @@ > diff -upr ladspa_sdk.orig/src/load.c ladspa_sdk/src/load.c > ---- ./load.c 2012-09-26 07:37:24.000000000 +0300 > -+++ ./load.c 2012-09-26 07:38:58.000000000 +0300 > +--- ladspa_sdk.orig/src/load.c 2012-09-26 07:37:24.000000000 +0300 > ++++ ladspa_sdk/src/load.c 2012-09-26 07:38:58.000000000 +0300 > @@ -54,6 +54,8 @@ dlopenLADSPA(const char * pcFilename, in > to search. */ > > @@ -11,8 +11,8 @@ diff -upr ladspa_sdk.orig/src/load.c ladspa_sdk/src/load.c > if (pcLADSPAPath) { > > diff -upr ladspa_sdk.orig/src/search.c ladspa_sdk/src/search.c > ---- ./search.c 2012-09-26 07:37:24.000000000 +0300 > -+++ ./search.c 2012-09-26 07:38:46.000000000 +0300 > +--- ladspa_sdk.orig/src/search.c 2012-09-26 07:37:24.000000000 +0300 > ++++ ladspa_sdk/src/search.c 2012-09-26 07:38:46.000000000 +0300 > @@ -99,10 +99,7 @@ LADSPAPluginSearch(LADSPAPluginSearchCal > > pcLADSPAPath = getenv("LADSPA_PATH"); > diff --git a/testing/ladspa/fix-memleak-in-plugin-scanning.patch b/testing/ladspa/fix-memleak-in-plugin-scanning.patch > index bc8ef7c4b3..76cb2e8640 100644 > --- a/testing/ladspa/fix-memleak-in-plugin-scanning.patch > +++ b/testing/ladspa/fix-memleak-in-plugin-scanning.patch > @@ -1,5 +1,5 @@ > ---- ./search.c.orig 2008-11-07 00:38:18.000000000 +0100 > -+++ ./search.c 2008-11-07 00:50:51.000000000 +0100 > +--- src/search.c.orig 2008-11-07 00:38:18.000000000 +0100 > ++++ src/search.c 2008-11-07 00:50:51.000000000 +0100 > @@ -83,6 +83,8 @@ > dlclose(pcFilename); > free(pcFilename); --- Unsubscribe: alpine-aports+unsubscribe@lists.alpinelinux.org Help: alpine-aports+help@lists.alpinelinux.org ---