Date: Thu, 19 Apr 2018 19:40:36 +0300
From: Taner Tas <taner76@gmail.com>
To: Natanael Copa <ncopa@alpinelinux.org>
Cc: alpine-aports@lists.alpinelinux.org
Subject: Re: [alpine-aports] [PATCH v3] testing/mame: new aport
Message-Id: <20180419194036.1483851d46d63f41d09d86d0@gmail.com>
In-Reply-To: <20180419154718.183542c7@ncopa-desktop.copa.dup.pw>
References: <20180302172909.24694-1-taner76@gmail.com>
	<20180416182936.20794-1-taner76@gmail.com>
	<20180419154718.183542c7@ncopa-desktop.copa.dup.pw>
Precedence: list
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 19 Apr 2018 15:47:18 +0200
Natanael Copa <ncopa@alpinelinux.org> wrote:

> > +prepare() {
> > +	cd "$srcdir"
> > +	if [ ! -d ${pkgname}-${pkgver} ]; then
> > +		7z x -o"${pkgname}-${pkgver}" ${pkgname}.zip
> > +	fi
> 
> Is it necessary to extract it with 7z? I though abuild will extract .zip for us.

Distribution file contains another zip file inside. Don't know why.
Actual zip file requires manual intervention and can't be extracted via "unzip". 


> > +	export OVERRIDE_CC=clang
> > +	export OVERRIDE_CXX=clang++
> 
> Does it require clang? Can it not be built with gcc?

Package actually builds with gcc. Clang compiles faster.
Also benchmarked both clang and gcc binaries.
Clang binary was smaller and performance is 10% better.


> 
> I think the depends need to be in global scope.
> 
fixed.


> > +	mkdir -p "$subpkgdir"/usr/share/"$pakgname"
> 
> pakgname looks like a typo.
yes. fixed.


> > +	mkdir -p "$subpkgdir"/usr/share/"$pakgname"
> 
> pakgname looks like a typo
yes.fixed.


> > +doc() {
> 
> Normally we install the files in $pkgdir from package() and let the
> default doc function move and compress the manpages to the -doc
> subpackage.
> 
I was having some issues with -doc package and decided to use this approach.
Now reverted to normal method.

I'm rebuilding package now. After successfull build I'll send v4.
Thanks for review.

-- 
Taner Tas <taner76@gmail.com>


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---