X-Original-To: alpine-aports@lists.alpinelinux.org Received: from mail-yw0-f194.google.com (mail-yw0-f194.google.com [209.85.161.194]) by lists.alpinelinux.org (Postfix) with ESMTP id 2E40C5C4F4C for ; Tue, 24 Apr 2018 05:28:15 +0000 (GMT) Received: by mail-yw0-f194.google.com with SMTP id h14-v6so5621409ywm.1 for ; Mon, 23 Apr 2018 22:28:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=sb+KsV+zAtRF+4Z5Q6Vjmme5PSuLTrUESL43ptf9K4Q=; b=THQXrw+RmWetEx2uT2O69YJyc/6tjZ8ITPLyziQ/HKiQYgchOGlITqCKhePtsORBbM T81iWCiUlG6BmRuKzNf9JLMO2U5TePAmpdUrwXmfEhuB/5dfx/VcX5bNGIdNMrglbDJb bcAVMODH+AZHU9GOCE7DOUJoOZZxaztUz/HQEwY196NgM9WoG0CrRND5jdoMAfwtE4/G y7P9MlgrzjPuR01w5+6Jbr4Qw2qRuov+QzGUXhYbfO+9CChSL9QqNbRDlTtGq8hZQQhQ FIP/SBcs1KNFi0dxeNOPrC7Xuk/bCZ5HrXbrVfotDXSXjxbGRIf7/mVNs4eujrWh2URG zSrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=sb+KsV+zAtRF+4Z5Q6Vjmme5PSuLTrUESL43ptf9K4Q=; b=BdR6IYria5treZWGsbSHFVXKdhi4VAtPzifcxNKUCxYDuLtO5dROsqHhpl0SN0fptQ mHNYQSoJcYYAolk2uh0oIxMXiDenmsXim5dMfeYuJb9S/m+y29Snt6gX2lz9OP601z/m ruYVb/0ZdsTJFtlnSkGOfUDjV1weF36Sk+EfDWa8DHW3H/sqJy3aRVuWHW+/ewYeAeuW 6gT7CjrGbIzMb8981mEucpmoRIQH4CkfPos4opbr/mQtNSHQfGMBjGJiX451ASNWojfJ htstVIno6ki9poUcNh/z4eLZsRnFdisCfDnTHdNrHEWG28g1V4hes3cOPOojb6X9NcPI s7MQ== X-Gm-Message-State: ALQs6tDT5P+iETLrJR9S3c/N5TfX3JIGKfLjUTrnDe1KXkSjDKF1y0yk AqOceDxNVhODPsTRaV+lMEM= X-Google-Smtp-Source: AIpwx4+gytxSP6ddbEDU37s4IEpcduaz4EXXnSosHi5PAuf0fCSlzbaoyIaNIR0mk9yfcehU3iiZhw== X-Received: by 2002:a81:2e97:: with SMTP id u145-v6mr11928262ywu.341.1524547694681; Mon, 23 Apr 2018 22:28:14 -0700 (PDT) Received: from alpine.Home ([31.223.30.32]) by smtp.gmail.com with ESMTPSA id c83-v6sm6223854ywh.10.2018.04.23.22.28.12 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 23 Apr 2018 22:28:13 -0700 (PDT) Date: Tue, 24 Apr 2018 08:28:11 +0300 From: Taner Tas To: Natanael Copa Cc: alpine-aports@lists.alpinelinux.org Subject: Re: [alpine-aports] [PATCH] main/mesa: Upgrade to 18.0.0 Message-Id: <20180424082811.396238aa44a4309828d911a3@gmail.com> In-Reply-To: <20180423212026.401075b5@ncopa-desktop.copa.dup.pw> References: <20180416182137.20463-1-taner76@gmail.com> <20180423212026.401075b5@ncopa-desktop.copa.dup.pw> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.31; x86_64-alpine-linux-musl) X-Mailinglist: alpine-aports Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 23 Apr 2018 21:20:26 +0200 Natanael Copa wrote: > > * Add aarch64 arch to use neon instructions > > It does not mention that we also enable vc4 driver for aarch64? You're right, will be mentioned. > > +armhf|aarch64) > > _gallium_drivers="${_gallium_drivers},vc4" > > - case "$CARCH" in > > - armhf) CFLAGS="$CFLAGS -mfpu=neon";; > > - esac > > + CFLAGS="$CFLAGS -mfpu=neon" > > This breaks build on aarch64: > > checking whether the C compiler works... no > configure: error: in `/home/ncopa/aports/main/mesa/src/mesa-18.0.0': > configure: error: C compiler cannot create executables > See `config.log' for more details > > > config.log has this explanation: > > configure:4657: checking whether the C compiler works > configure:4679: gcc -Os -mfpu=neon -D_XOPEN_SOURCE=700 -Os -Wl,--as-needed conftest.c >&5 > gcc: error: unrecognized command line option '-mfpu=neon' > > We cannot add -mfpu=neon to CFLAGS on aarch64 > > But as I understand your patch, we want enable vc4 driver on aarch64 too? > > Is it ok if I apply it with this change: > > diff --git a/main/mesa/APKBUILD b/main/mesa/APKBUILD > index c0a8c4f997..404b0385d4 100644 > --- a/main/mesa/APKBUILD > +++ b/main/mesa/APKBUILD > @@ -50,7 +50,9 @@ x86*) > ;; > armhf|aarch64) > _gallium_drivers="${_gallium_drivers},vc4" > - CFLAGS="$CFLAGS -mfpu=neon" > + case "$CARCH" in > + armhf) CFLAGS="$CFLAGS -mfpu=neon";; > + esac > ;; Yes, vc4 can be enabled on aarch64 for Rpi3 too. Enabling -mfpu=neon seems doesn't needed on aarch64, thus separately enabling on armhf is enough as mentiones above. I prepared another PR on github with newer version and suggested changes. Please refer to: https://github.com/alpinelinux/aports/pull/4107 Thanks for review. -- Taner --- Unsubscribe: alpine-aports+unsubscribe@lists.alpinelinux.org Help: alpine-aports+help@lists.alpinelinux.org ---