Subject: [alpine-aports] [PATCH] testing/simple-mtpfs: new aport

From: Milan P. Stanić <[email-masked]>
Date: Sat, 23 Jun 2018 21:40:47 +0200

https://github.com/phatina/simple-mtpfs
filesystem driver and CLI utility for mounting MTP based devices
---
 testing/simple-mtpfs/APKBUILD | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)
 create mode 100644 testing/simple-mtpfs/APKBUILD

diff --git a/testing/simple-mtpfs/APKBUILD b/testing/simple-mtpfs/APKBUILD
new file mode 100644
index 0000000000..81d3c431d6
--- /dev/null
+++ b/testing/simple-mtpfs/APKBUILD
@@ -0,0 +1,30 @@
+# Contributor: Milan P. Stanić <[email-masked]>
+# Maintainer: Milan P. Stanić <[email-masked]>
+pkgname=simple-mtpfs
+pkgver=0.3.0
+pkgrel=0
+pkgdesc="filesystem driver and CLI utility for MTP based devices"
+url="https://github.com/phatina/simple-mtpfs"
+arch="all"
+license="GPL-2"
+depends=""
+makedepends="libmtp-dev libusb-dev fuse-dev"
+install=""
+subpackages="$pkgname-doc"
+source="https://github.com/phatina/simple-mtpfs/archive/${pkgname}-${pkgver}.tar.gz"
+builddir="$srcdir/${pkgname}-${pkgname}-${pkgver}"
+
+build() {
+	cd "$builddir"
+  ./autogen.sh
+	./configure \
+		--prefix=/usr
+	make
+}
+
+package() {
+	cd "$builddir"
+	DESTDIR="$pkgdir" make install
+}
+
+sha512sums="7d2da152708c01ddd2a39c1b56cba6470bfd320b92507530cdd8fc4f25f9500ff817eac6a5d19c775f31029ae6a0baef693987c59453c60c688b84934378f772  simple-mtpfs-0.3.0.tar.gz"
-- 
2.18.0

---
Unsubscribe:  [email-masked]
Help:         [email-masked]
---

---

From: Leonardo Arena <[email-masked]>
Date: Wed, 18 Jul 2018 12:12:40 +0200

Hi,

sorry for the late review. Please see few comments below.

> +++ b/testing/simple-mtpfs/APKBUILD

The license ID is invalid according to the standard we use:
https://spdx.org/licenses/

> +makedepends="libmtp-dev libusb-dev fuse-dev"

Optionally you may remove empy variables.

> +builddir="$srcdir/${pkgname}-${pkgname}-${pkgver}"

Indent broken. In any case "autogen.sh" belongs to prepare() function.

Thanks!

/eo