Subject: [alpine-aports] [PATCH] testing/cava: new aport

From: Sascha Paunovic <[email-masked]>
Date: Sun, 1 Jul 2018 16:45:15 +0200

---
 testing/cava/APKBUILD | 38 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 38 insertions(+)
 create mode 100644 testing/cava/APKBUILD

diff --git a/testing/cava/APKBUILD b/testing/cava/APKBUILD
new file mode 100644
index 0000000000..b2dfe566e7
--- /dev/null
+++ b/testing/cava/APKBUILD
@@ -0,0 +1,38 @@
+# Contributor: Sascha Paunovic <[email-masked]>
+# Maintainer: Sascha Paunovic <[email-masked]>
+#TODO: pulseaudio & sndio subpackage
+pkgname=cava
+pkgver=0.6.1
+pkgrel=0
+pkgdesc="console based audio visualizer for ALSA & more"
+url="https://github.com/karlstav/cava"
+arch="all"
+license="MIT"
+makedepends="fftw-dev ncurses-dev alsa-lib-dev libtool"
+source="$pkgname-$pkgver.tar.gz::https://github.com/karlstav/$pkgname/archive/$pkgver.tar.gz"
+builddir="$srcdir/$pkgname-$pkgver"
+
+build() {
+	cd "$builddir"
+	autoreconf -if
+	./configure \
+		--build=$CBUILD \
+		--host=$CHOST \
+		--prefix=/usr \
+		--sysconfdir=/etc \
+		--mandir=/usr/share/man \
+		--localstatedir=/var
+	make
+}
+
+check() {
+	cd "$builddir"
+	make check # currently doesn't do much, but better than nothing
+}
+
+package() {
+	cd "$builddir"
+	make DESTDIR="$pkgdir" install
+}
+
+sha512sums="fb8a685f5c758ca1d95d3bbafadd4dbbf109592b6c3052b0821c2f69f3423e0af7657de4c3c1cdbd1523748bf56a09cbf706afa404051a6fba8139ca128ebecb  cava-0.6.1.tar.gz"
-- 
2.18.0

---
Unsubscribe:  [email-masked]
Help:         [email-masked]
---

---

From: Leonardo Arena <[email-masked]>
Date: Wed, 11 Jul 2018 15:40:32 +0200

Hi,

please see some comments below:

> +++ b/testing/cava/APKBUILD

Automake and autoconf are missing.

> +source="$pkgname-$pkgver.tar.gz::https://github.com/
> karlstav/$pkgname/archive/$pkgver.tar.gz"

autoreconf should be moved into "prepare()" which should run also
"default_prepare" first.

> +sha512sums="fb8a685f5c758ca1d95d3bbafadd4dbbf109592b6c3052b0821c2f69f342
> 3e0af7657de4c3c1cdbd1523748bf56a09cbf706afa404051a6fba8139ca128ebecb
> cava-0.6.1.tar.gz"
>
>

Everything else looks good, thanks!

/eo