Subject: [alpine-aports] [PATCH] main/gnokii: build fix for gcc8

From: alpine-mips-patches <[email-masked]>
Date: Mon, 12 Nov 2018 16:22:51 +0000

This is yet another package that assumes GNU-style inline keyword handling
and fails with the "undefined reference to `foo'" linker error where foo is
some inline function (here local_atoi).

Instead of fixing the source, pass -std=gnu89 in CFLAGS because
1) this is shorter and easier;
2) the project is actually written in GNU C89 dialect;
3) upstream is not active (the last release was in 2011).

With this change in place gnokii-0.6.31-gcc5.patch can be removed,
suggesting the -std=gnu89 approach is also more future-proof for any
further changes in compiler's inliner implementation.
---
 main/gnokii/APKBUILD | 1 +
 1 file changed, 1 insertion(+)

diff --git a/main/gnokii/APKBUILD b/main/gnokii/APKBUILD
index 21be793db9..b7fc0ab82c 100644
--- a/main/gnokii/APKBUILD
+++ b/main/gnokii/APKBUILD
@@ -36,6 +36,7 @@ prepare() {
 
 build() {
 	cd "$_builddir"
+	CFLAGS="$CFLAGS -std=gnu89" \
 	./configure \
 		--build=$CBUILD \
 		--host=$CHOST \
-- 
2.19.1

---
Unsubscribe:  [email-masked]
Help:         [email-masked]
---

---

From: Leonardo Arena <[email-masked]>
Date: Tue, 13 Nov 2018 11:51:57 +0100

Hi,

thank you for your contribution.

On Mon, Nov 12, 2018 at 6:39 PM alpine-mips-patches <[email-masked]>
wrote:

[snip]

> @@ -36,6 +36,7 @@ prepare() {

Please bump pkgrel everytime you touch APKBUILD.

Thanks!

/eo