X-Original-To: alpine-aports@lists.alpinelinux.org Received: from mx12.valuehost.ru (mx12.valuehost.ru [217.112.42.215]) by lists.alpinelinux.org (Postfix) with ESMTP id 5B1D25C5960 for ; Mon, 12 Nov 2018 17:39:00 +0000 (GMT) Received: from mx7.valuehost.ru (unknown [127.0.0.255]) by mx12.valuehost.ru (Postfix) with ESMTP id 3B72357774 for ; Mon, 12 Nov 2018 20:38:58 +0300 (MSK) From: alpine-mips-patches Date: Mon, 12 Nov 2018 16:22:51 +0000 Subject: [alpine-aports] [PATCH] main/gnokii: build fix for gcc8 To: alpine-aports@lists.alpinelinux.org Message-Id: <20181112173858.3B72357774@mx12.valuehost.ru> X-Mailinglist: alpine-aports Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: This is yet another package that assumes GNU-style inline keyword handling and fails with the "undefined reference to `foo'" linker error where foo is some inline function (here local_atoi). Instead of fixing the source, pass -std=gnu89 in CFLAGS because 1) this is shorter and easier; 2) the project is actually written in GNU C89 dialect; 3) upstream is not active (the last release was in 2011). With this change in place gnokii-0.6.31-gcc5.patch can be removed, suggesting the -std=gnu89 approach is also more future-proof for any further changes in compiler's inliner implementation. --- main/gnokii/APKBUILD | 1 + 1 file changed, 1 insertion(+) diff --git a/main/gnokii/APKBUILD b/main/gnokii/APKBUILD index 21be793db9..b7fc0ab82c 100644 --- a/main/gnokii/APKBUILD +++ b/main/gnokii/APKBUILD @@ -36,6 +36,7 @@ prepare() { build() { cd "$_builddir" + CFLAGS="$CFLAGS -std=gnu89" \ ./configure \ --build=$CBUILD \ --host=$CHOST \ -- 2.19.1 --- Unsubscribe: alpine-aports+unsubscribe@lists.alpinelinux.org Help: alpine-aports+help@lists.alpinelinux.org ---