Date: Fri, 4 Jan 2019 08:24:40 +0200
From: Timo Teras <timo.teras@iki.fi>
To: "Milan P. =?UTF-8?B?U3RhbmnEhw==?=" <mps@arvanta.net>
Cc: alpine-aports@lists.alpinelinux.org
Subject: Re: [alpine-aports] [PATCH] community/libcoro: fix build on armv7
Message-ID: <20190104082440.0ace5e56@vostro>
In-Reply-To: <20190103180636.4774-1-mps@arvanta.net>
References: <20190103180636.4774-1-mps@arvanta.net>
Precedence: list
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi,

We also have now main/libucontext for the makecontext() support. Would
it make sense to use CORO_UCONTEXT + libucontext; or is the CORO_SJLJ
more favorable?

Timo

On Thu,  3 Jan 2019 19:06:36 +0100
Milan P. Stani=C4=87 <mps@arvanta.net> wrote:

> use CORO_SJLJ build C flag on all architectures
> ---
>  community/libcoro/APKBUILD | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
>=20
> diff --git a/community/libcoro/APKBUILD b/community/libcoro/APKBUILD
> index cdd5562aa7..0e0bd4307b 100644
> --- a/community/libcoro/APKBUILD
> +++ b/community/libcoro/APKBUILD
> @@ -2,7 +2,7 @@
>  # Maintainer: Jakub Jirutka <jakub@jirutka.cz>
>  pkgname=3Dlibcoro
>  pkgver=3D6.513
> -pkgrel=3D0
> +pkgrel=3D1
>  pkgdesc=3D"Coroutines (cooperative multitasking) in a portable fashion
> implemented in C" url=3D"http://software.schmorp.de/pkg/libcoro.html"
>  arch=3D"all"
> @@ -42,11 +42,7 @@ prepare() {
>  build() {
>  	cd "$builddir"
> =20
> -	CFLAGS=3D"-fPIC -pedantic -Wall"
> -	case "$CARCH" in
> -		x86* | armv7*) CFLAGS=3D"$CFLAGS -DCORO_ASM";;
> -		*) CFLAGS=3D"$CFLAGS -DCORO_SJLJ";;
> -	esac
> +	CFLAGS=3D"-DCORO_SJLJ -fPIC -pedantic -Wall"
> =20
>  	# Build shared lib.
>  	$CC $CFLAGS -O3 -c coro.c



---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---