Subject: [alpine-aports] [PATCH] community/py-ansi2html: move from testing

From: Drew DeVault <[email-masked]>
Date: Mon, 11 Mar 2019 13:01:26 -0600

---
 {testing => community}/py-ansi2html/APKBUILD | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 rename {testing => community}/py-ansi2html/APKBUILD (100%)

diff --git a/testing/py-ansi2html/APKBUILD b/community/py-ansi2html/APKBUILD
similarity index 100%
rename from testing/py-ansi2html/APKBUILD
rename to community/py-ansi2html/APKBUILD
-- 
2.21.0

---
Unsubscribe:  [email-masked]
Help:         [email-masked]
---

---

From: Leonardo Arena <[email-masked]>
Date: Wed, 3 Apr 2019 10:48:42 +0200

Hi,

>  rename {testing => community}/py-ansi2html/APKBUILD (100%)
we are getting rid of python2 packages, and its prefix has been renamed to
py3. Also the packages is missing check() if tests are available or it
needs to be explicitly disabled before moving into community.

Would please submit a new patch?

Thanks!

/eo

---

From: Drew DeVault <[email-masked]>
Date: Wed, 3 Apr 2019 10:50:07 -0400

> needs to be explicitly disabled before moving into community.

We haven't come to consensus on how to proceed with Python 2 deprecation
yet (I was leading that effort, will hopefully get it rolling soon), so
I'd rather not drop it for now. Especially since this package already
has python2 support, and dropping it is a breaking change, I'd rather
hold off until consensus on the Python 2 problem is reached.

This package also has a check() function. Are you looking at the right
patch version? v3 is here:

https://patchwork.alpinelinux.org/patch/4609/

I think this patch hits all fo the marks. Let me know if I missed
something.

---

---

From: Keith Maxwell <[email-masked]>
Date: Mon, 8 Apr 2019 23:44:16 +0100

Hello Drew

> I think this patch hits all fo the marks. Let me know if I missed

I agree the patch has a check function, but I think it also includes the
line:

+options="!check" # upstream tests don't work unless module is installed

I haven't tried building the package, but what I read in the reference
suggests this will stop the tests running:
https://wiki.alpinelinux.org/wiki/APKBUILD_Reference#options

-- 
Kind Regards

Keith Maxwell

---

---

From: Drew DeVault <[email-masked]>
Date: Mon, 8 Apr 2019 18:45:40 -0400

> https://wiki.alpinelinux.org/wiki/APKBUILD_Reference#options

My mistake. Still, the comment there should speak for itself. The patch
is suitable for inclusion imo.

---