X-Original-To: alpine-aports@lists.alpinelinux.org
Received: from mail.cmpwn.com (mail.cmpwn.com [45.56.77.53])
	by lists.alpinelinux.org (Postfix) with ESMTP id 49F88F84F65
	for <alpine-aports@lists.alpinelinux.org>; Fri, 15 Mar 2019 20:01:26 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=cmpwn.com; s=cmpwn;
	t=1552680196; bh=4flxQ+a7zZCchREFGepYcNbwbA+OUQlUxleSvaaVp30=;
	h=Date:From:To:Cc:Subject:References:In-Reply-To;
	b=4Udzo1qSZC4mjv3ZUB5O6FErypaj4fuklCijTcNrRGb4A+qAlGmIM+WulJqgsD7FO
	 qy/K8kUZ+IRLcOXgOPxlD/g2py5FneDHUM9SyHgeHAN6sP9LhACRFS6hUL3rnSVl1s
	 6/kemIzq6V2tUjx5gjHPqcZGjMjvI3F4ukUmFNnE=
Date: Fri, 15 Mar 2019 16:01:24 -0400
From: Drew DeVault <sir@cmpwn.com>
To: Kevin Daudt <kdaudt@alpinelinux.org>
Cc: alpine-aports@lists.alpinelinux.org, Ivan Tham <pickfire@riseup.net>
Subject: Re: [alpine-aports] [PATCHv3] testing/ubase: update to 20171010
Message-ID: <20190315200124.GC16498@homura.localdomain>
References: <20180115040029.21669-1-sir@cmpwn.com>
 <20190315195217.GA4397@alpha>
X-Mailinglist: alpine-aports
Precedence: list
List-Id: Alpine Development <alpine-aports.lists.alpinelinux.org>
List-Unsubscribe: 
	<mailto:alpine-aports+unsubscribe@lists.alpinelinux.org?subject=unsubscribe>
List-Post: <mailto:alpine-aports@lists.alpinelinux.org>
List-Help: <mailto:alpine-aports+help@lists.alpinelinux.org?subject=help>
List-Subscribe: 
	<mailto:alpine-aports+subscribe@lists.alpinelinux.org?subject=subscribe>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190315195217.GA4397@alpha>
X-GNU: Terry Pratchett

Thanks for the review! I see a lot of problems in this patch myself
(it's over a year old now), I should revisit it anyway.

On 2019-03-15  8:52 PM, Kevin Daudt wrote:
> Just running the binary with -v or -h is not accepted as a check. In
> that case it's prefered to leave `options="!check"`.

I have heard the opposite in the past. Can you update this page?

https://wiki.alpinelinux.org/wiki/Creating_an_Alpine_package#Code_review


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---