X-Original-To: alpine-aports@lists.alpinelinux.org Received: from mx1.tetrasec.net (mx1.tetrasec.net [74.117.190.25]) by lists.alpinelinux.org (Postfix) with ESMTP id 3050FF85622 for ; Thu, 4 Apr 2019 11:56:14 +0000 (UTC) Received: from mx1.tetrasec.net (mail.local [127.0.0.1]) by mx1.tetrasec.net (Postfix) with ESMTP id 006059E1E9F; Thu, 4 Apr 2019 11:56:14 +0000 (UTC) Received: from ncopa-desktop.copa.dup.pw (67.63.200.37.customer.cdi.no [37.200.63.67]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: alpine@tanael.org) by mx1.tetrasec.net (Postfix) with ESMTPSA id EFE8E9E0468; Thu, 4 Apr 2019 11:56:12 +0000 (UTC) Date: Thu, 4 Apr 2019 13:56:08 +0200 From: Natanael Copa To: Drew DeVault Cc: alpine-aports@lists.alpinelinux.org, Kaarle Ritvanen Subject: Re: [alpine-aports] [PATCH v3 01/10] community/py-factory-boy: adopt APKBUILD Message-ID: <20190404135608.4e569494@ncopa-desktop.copa.dup.pw> In-Reply-To: <20190403201642.14637-1-sir@cmpwn.com> References: <20190403201642.14637-1-sir@cmpwn.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-alpine-linux-musl) X-Mailinglist: alpine-aports Precedence: list List-Id: Alpine Development List-Unsubscribe: List-Post: List-Help: List-Subscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 3 Apr 2019 16:16:33 -0400 Drew DeVault wrote: > --- > community/py-factory-boy/APKBUILD | 17 ++++++++++------- > 1 file changed, 10 insertions(+), 7 deletions(-) > > diff --git a/community/py-factory-boy/APKBUILD b/community/py-factory-boy/APKBUILD > index 24b0876c58..cdfcea6732 100644 > --- a/community/py-factory-boy/APKBUILD > +++ b/community/py-factory-boy/APKBUILD > @@ -1,17 +1,19 @@ > # Contributor: Kaarle Ritvanen > -# Contributor: Drew DeVault > -# Maintainer: Kaarle Ritvanen > +# Maintainer: Drew DeVault I assume you have verified this with Kaarle (kunkku)? > pkgname=py-factory-boy > _pkgname=factory_boy > pkgver=2.11.1 > -pkgrel=1 > +pkgrel=2 > pkgdesc="A verstile test fixtures replacement based on thoughtbot's factory_girl for Ruby" > url=https://github.com/rbarrois/factory_boy > arch=noarch > license=MIT > -depends="py-faker py-six" > -makedepends="py-setuptools" > -checkdepends="py-mock py-django py-sqlalchemy" > +_py2_deps="py2-faker py2-six" > +_py2_deps="py3-faker py3-six" Typo here. _py2 should be _py3 > +makedepends="$_py2_deps $_py3_deps py2-setuptools py3-setuptools" > +checkdepends=" > + py2-mock py3-mock py2-django py3-django py2-sqlalchemy py3-sqlalchemy > +" > subpackages="py2-${pkgname#py-}:_py2 py3-${pkgname#py-}:_py3" > source="$pkgname-$pkgver.tar.gz::https://github.com/FactoryBoy/$_pkgname/archive/$pkgver.tar.gz" > builddir=$srcdir/$_pkgname-$pkgver > @@ -47,12 +49,13 @@ package() { > > _py2() { > replaces="py-factory-boy" > - depends="py-six" > + depends="$_py2_deps" > cd "$builddir" > _py python2 > } > > _py3() { > + depends="$_py3_deps" > cd "$builddir"-py3 > _py python3 > } I'm gonna clean up the typo for you and merge together with the python 3.7 rebuild. Thanks! -nc --- Unsubscribe: alpine-aports+unsubscribe@lists.alpinelinux.org Help: alpine-aports+help@lists.alpinelinux.org ---