X-Original-To: alpine-aports@lists.alpinelinux.org
Received: from fx.arvanta.net (static-213-198-238-194.adsl.eunet.rs [213.198.238.194])
	by lists.alpinelinux.org (Postfix) with ESMTP id 0A85DF815EE
	for <alpine-aports@lists.alpinelinux.org>; Sat,  1 Jun 2019 12:35:41 +0000 (UTC)
Received: from arya.arvanta.net (arya.arvanta.net [10.5.1.6])
	by fx.arvanta.net (Postfix) with ESMTP id 71B3F618C;
	Sat,  1 Jun 2019 14:35:40 +0200 (CEST)
Date: Sat, 1 Jun 2019 14:35:40 +0200
From: Milan =?utf-8?Q?P=2E_Stani=C4=87?= <mps@arvanta.net>
To: Marian Buschsieweke <marian.buschsieweke@ovgu.de>
Cc: alpine-aports@lists.alpinelinux.org
Subject: Re: [alpine-aports] [PATCH 5/6] testing/pulseview: New aport
Message-ID: <20190601123540.GA16853@arya.arvanta.net>
References: <20190404165559.6565-1-marian.buschsieweke@ovgu.de>
 <20190404165559.6565-5-marian.buschsieweke@ovgu.de>
X-Mailinglist: alpine-aports
Precedence: list
List-Id: Alpine Development <alpine-aports.lists.alpinelinux.org>
List-Unsubscribe: 
	<mailto:alpine-aports+unsubscribe@lists.alpinelinux.org?subject=unsubscribe>
List-Post: <mailto:alpine-aports@lists.alpinelinux.org>
List-Help: <mailto:alpine-aports+help@lists.alpinelinux.org?subject=help>
List-Subscribe: 
	<mailto:alpine-aports+subscribe@lists.alpinelinux.org?subject=subscribe>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190404165559.6565-5-marian.buschsieweke@ovgu.de>
User-Agent: Mutt/1.12.0 (2019-05-25)

Hi,

On Thu, 2019-04-04 at 18:55, Marian Buschsieweke wrote:
> A QT-based GUI frontend for sigrok
> https://sigrok.org/wiki/PulseView
...
> +makedepends="libserialport-dev libsigrok-dev libsigrokdecode-dev glibmm-dev
> +             qt5-qtbase-dev qt5-qtsvg-dev boost-dev cmake"
> +# Without qt5-qtsvg some icons in the GUI are missing
> +depends="qt5-qtsvg"
> +arch="all"
> +license="GPL-3.0-only"
> +source="http://sigrok.org/download/source/$pkgname/$pkgname-$pkgver.tar.gz"
> +subpackages="$pkgname-doc"
> +builddir="$srcdir/$pkgname-$pkgver"
> +
> +build() {
> +	cd "${builddir}"

Small note: braces ({}) around variables should not be used without
reason. It is some kind of unwritten policy, for now at least.

> +	cmake . -DCMAKE_INSTALL_PREFIX=/usr \
> +		-DCMAKE_INSTALL_BINDIR=/usr/bin \
> +		-DCMAKE_INSTALL_SBINDIR=/usr/sbin \
> +		-DCMAKE_INSTALL_SYSCONFDIR=/etc/hiawatha \
> +		-DCMAKE_INSTALL_LIBDIR=/usr/lib \
> +		-DCMAKE_INSTALL_MANDIR=/usr/share/man \
> +		-DENABLE_TESTS=y \
> +		-DENABLE_DECODE=y
> +	make
...

Tried build package but I've got next message:
---
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found PkgConfig: /usr/bin/pkg-config (found version "1.6.1")
CMake Error at CMakeLists.txt:92 (message):
  libsigrok C++ bindings missing, check libsigrok's 'configure' output
  (missing dependencies?)


-- Configuring incomplete, errors occurred!
See also
"/home/mps/aports/testing/pulseview/src/pulseview-0.4.1/CMakeFiles/CMakeOutput.log".
>>> ERROR: pulseview: build failed
>>> pulseview: Uninstalling dependencies...
(1/181) Purging .makedepends-pulseview (0)
(2/181) Purging libsigrok-dev (0.5.1-r0)
---

Please, look at the issue and resend if it works for you.

-- 
regards


---
Unsubscribe:  alpine-aports+unsubscribe@lists.alpinelinux.org
Help:         alpine-aports+help@lists.alpinelinux.org
---