Received: from vps892.directvps.nl (ikke.info [178.21.113.177])	by
 nld3-dev1.alpinelinux.org (Postfix) with ESMTPS id E38ED781A73	for
 <~alpine/aports@lists.alpinelinux.org>; Mon, 19 Aug 2019 09:30:23 +0000 (UTC)
Received: by vps892.directvps.nl (Postfix, from userid 1008)
	id 851014400EE; Mon, 19 Aug 2019 11:30:22 +0200 (CEST)
Date: Mon, 19 Aug 2019 11:30:22 +0200
From: Kevin Daudt <kdaudt@alpinelinux.org>
To: Noam Preil <pleasantatk@gmail.com>
Cc: ~alpine/aports@lists.alpinelinux.org
Subject: Re: [PATCH] testing/pavucontrol: new aport
Message-ID: <20190819093022.GB13620@alpha>
References: <20190819052929.18671-1-pleasantatk@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190819052929.18671-1-pleasantatk@gmail.com>
User-Agent: Mutt/1.12.1 (2019-06-15)

Hello Noam,

I've provided some feedback inline

On Mon, Aug 19, 2019 at 01:29:29AM -0400, Noam Preil wrote:
> https://freedesktop.org/software/pulseaudio/pavucontrol/
> Pulseaudio Volume Control, GTK based mixer for Pulseaudio
> ---
>  testing/pavucontrol/APKBUILD | 39 ++++++++++++++++++++++++++++++++++++
>  1 file changed, 39 insertions(+)
>  create mode 100644 testing/pavucontrol/APKBUILD
> 
> diff --git a/testing/pavucontrol/APKBUILD b/testing/pavucontrol/APKBUILD
> new file mode 100644
> index 00000000..cf1acf77
> --- /dev/null
> +++ b/testing/pavucontrol/APKBUILD
> @@ -0,0 +1,39 @@
> +# Maintainer: Noam Preil <pleasantatk@gmail.com>
> +pkgname="pavucontrol"
> +pkgver="4.0"
> +pkgrel=0
> +pkgdesc="Pulseaudio Volume Control, GTK based mixer for Pulseaudio"
> +url="https://freedesktop.org/software/pulseaudio/pavucontrol/"
> +arch="all"
> +license="GPL-2.0-or-later"
> +depends="pulseaudio"
> +makedepends="m4 automake gtkmm3-dev glade-dev pulseaudio-dev"
> +install=""

Empty variables can be removed.

> +source="https://freedesktop.org/software/pulseaudio/pavucontrol/pavucontrol-$pkgver.tar.gz"
> +
> +build() {
> +	# Replace with proper build command(s)

This instructional comments can be removed.

> +	./configure \
> +		--build=$CBUILD \
> +		--host=$CHOST \
> +		--prefix=/usr \
> +		--sysconfdir=/etc \
> +		--mandir=/usr/share/man \
> +		--localstatedir=/var \
> +		--datadir=/usr/share \
> +		--disable-lynx \
> +                --disable-nls

Please make sure you use tabs consistently, this line is indented with
spaces.

> +	make
> +}
> +
> +check() {
> +	# Replace with proper check command(s)
> +	make check
> +}
> +
> +package() {
> +	# Replace with proper package command(s)
> +	make DESTDIR="$pkgdir" install
> +}
> +
> +sha512sums="fd58657d399349f22b52b55f946ea9e62f6278f087c945a54f4b61aa72fde92fb69f9bf7762f5db88235a0038535023faf92d8bb1f5d9f8b7168ccb2166386d3  pavucontrol-4.0.tar.gz"

When building, it fails because:

> configure: error: Package requirements ( gtkmm-3.0 >= 3.0 sigc++-2.0
> libcanberra-gtk3 >= 0.16 ) were not met:
> 
> Package 'libcanberra-gtk3', required by 'virtual:world', not found

So you need to add libcanberra-gtk3 as a (make)depends. 


Kind regards, Kevin
> -- 
> 2.23.0