Date: Wed, 11 Sep 2019 15:12:37 -0300
From: Leo <thinkabit.ukim@gmail.com>
To: ~alpine/aports@lists.alpinelinux.org
Subject: Re: [PATCH] testing/xfce4-pulseaudio-plugin: new aport
Message-ID: <20190911151237.65248b7f@Impreza>
In-Reply-To: <20190911180624.22112-1-voroskoi@gmail.com>
References: <20190911180624.22112-1-voroskoi@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Wed, 11 Sep 2019 20:06:24 +0200
V=C3=96R=C3=96SK=C5=90I Andr=C3=A1s <voroskoi@gmail.com> wrote:

> https://goodies.xfce.org/projects/panel-plugins/xfce4-pulseaudio-plugin
> Xfce panel plugin for pulseaudio mixer control
> ---
>  testing/xfce4-pulseaudio-plugin/APKBUILD | 32
> ++++++++++++++++++++++++ 1 file changed, 32 insertions(+)
>  create mode 100644 testing/xfce4-pulseaudio-plugin/APKBUILD
>=20
> diff --git a/testing/xfce4-pulseaudio-plugin/APKBUILD
> b/testing/xfce4-pulseaudio-plugin/APKBUILD new file mode 100644
> index 0000000000..8aec18eaa8
> --- /dev/null
> +++ b/testing/xfce4-pulseaudio-plugin/APKBUILD
> @@ -0,0 +1,32 @@
> +# Contributor: V=C3=96R=C3=96SK=C5=90I Andr=C3=A1s <voroskoi@gmail.com>
> +# Maintainer:
> +pkgname=3D"xfce4-pulseaudio-plugin"
> +pkgver=3D"0.4.2"
> +pkgrel=3D0
> +pkgdesc=3D"Xfce panel plugin for pulseaudio mixer control."
> +url=3D"https://goodies.xfce.org/projects/panel-plugins/xfce4-pulseaudio-=
plugin"
> +arch=3D"all"
> +license=3D"GPL-2.0"

Please use the proper SPDX identifier for the license.

> +depends=3D""

Empty variable can be removed for brevity

> +makedepends=3D"xfce4-panel-dev pulseaudio-dev libxfce4ui-dev dbus-dev
> dbus-glib-dev libnotify-dev"
> +install=3D""

Same here.

> +options=3D"!check"

Please add a comment telling why check is disabled

> +subpackages=3D"$pkgname-lang"
> +source=3D"https://archive.xfce.org/src/panel-plugins/$pkgname/${pkgver%.=
*}/$pkgname-$pkgver.tar.bz2"
> +builddir=3D"$srcdir/$pkgname-$pkgver"

Default value, can be removed.

> +
> +build() {
> +	./configure \
> +	    --prefix=3D/usr \
> +	    --sysconfdir=3D/etc \
> +	    --libexecdir=3D/usr/lib \
> +	    --localstatedir=3D/var \
> +	    --disable-static
> +	make
> +}
> +
> +package() {
> +	make DESTDIR=3D"$pkgdir" install
> +}
> +
> +sha512sums=3D"94184fe7379a7f1763d606fe3c45186767a43180329b43c8cba04b76ae=
5e1b2249531fc1fb6304da9bb03e7475ad65f861341253ead530d9a945165b4eb9e46e
>  xfce4-pulseaudio-plugin-0.4.2.tar.bz2"