Received: from vps892.directvps.nl (ikke.info [178.21.113.177])
	by nld3-dev1.alpinelinux.org (Postfix) with ESMTPS id 21BC3781934
	for <alpine-aports@lists.alpinelinux.org>; Fri,  4 Oct 2019 19:33:57 +0000 (UTC)
Received: by vps892.directvps.nl (Postfix, from userid 1008)
	id 88B4F4400AE; Fri,  4 Oct 2019 21:33:56 +0200 (CEST)
Date: Fri, 4 Oct 2019 21:33:56 +0200
From: Kevin Daudt <me@ikke.info>
To: "xrs =:-)" <xrs@mail36.net>
Cc: alpine-aports@lists.alpinelinux.org
Subject: Re: [PATCH 1/4] testing/libidn2: new aport
Message-ID: <20191004193356.GC160327@alpha>
References: <20190928175728.4614-1-xrs@mail36.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190928175728.4614-1-xrs@mail36.net>
User-Agent: Mutt/1.12.1 (2019-06-15)

On Sat, Sep 28, 2019 at 07:57:26PM +0200, xrs =:-) wrote:
> https://www.gnu.org/software/libidn/#libidn2
> Encode/Decode library for internationalized domain names
> testing/
> ---
>  testing/libidn2/APKBUILD | 40 ++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 40 insertions(+)
>  create mode 100644 testing/libidn2/APKBUILD
> 
> diff --git a/testing/libidn2/APKBUILD b/testing/libidn2/APKBUILD
> new file mode 100644
> index 0000000000..6801620b5e
> --- /dev/null
> +++ b/testing/libidn2/APKBUILD
> @@ -0,0 +1,40 @@
> +# Contributor: xrs <xrs@mail36.net>
> +# Maintainer: xrs <xrs@mail36.net>
> +pkgname="libidn2"
> +pkgver="2.2.0"
> +pkgrel=0
> +pkgdesc="Encode/Decode library for internationalized domain names"
> +url="https://www.gnu.org/software/libidn/#libidn2"
> +arch="all"
> +license="LGPL-3.0-or-later"
> +depends="libunistring gnu-libiconv"
> +depends_dev="libunistring-dev gnu-libiconv-dev"
> +makedepends="$depends_dev"
> +install=""
> +subpackages="$pkgname-dev $pkgname-doc"
> +source="https://ftp.gnu.org/gnu/libidn/$pkgname-$pkgver.tar.gz"
> +builddir="$srcdir/$pkgname-$pkgver"
> +
> +prepare() {
> +	default_prepare
> +	cd "$builddir"
> +}
> +
> +build() {
> +	cd "$builddir"
> +	./configure \
> +		--prefix=/usr
> +	make
> +}
> +
> +check() {
> +	cd "$builddir"
> +	make -C tests
> +}
> +
> +package() {
> +	cd "$builddir"
> +	make DESTDIR="$pkgdir" install
> +}
> +
> +sha512sums="ccf56056a378d49a28ff67a2a23cd3d32ce51f86a78f84839b98dad709a1d0d03ac8d7c1496f0e4d3536bca00e3d09d34d76a37317b2ce87e3aa66bdf4e877b8  libidn2-2.2.0.tar.gz"
> -- 
> 2.22.0

Hello xrs,

Thanks for your submission! I noticed that libidn2[0] is already in
aports. so you could drop that. I have given some feedback on the other
patches. Please fix them and submit them again.

To help you catch issues like these, you could use atools[1], which
contains apkbuild-lint, which will report style issues.

Another option is to submit a merge request in our gitlab[2] instance,
where we have a CI pipeline setup. Here[3] you see the linting output
for this patch series.

If you have any questions or concerns, feel free to ask.

Kind regards, Kevin

[0]:https://pkgs.alpinelinux.org/package/edge/main/x86_64/libidn2
[1]:https://gitlab.alpinelinux.org/Leo/atools
[2]:https://gitlab.alpinelinux.org/alpine/aports
[3]:https://gitlab.alpinelinux.org/kdaudt/aports/-/jobs/2141