Received: from vps892.directvps.nl (ikke.info [178.21.113.177])
	by nld3-dev1.alpinelinux.org (Postfix) with ESMTPS id 59AFD7819B0
	for <alpine-aports@lists.alpinelinux.org>; Fri,  4 Oct 2019 19:34:06 +0000 (UTC)
Received: by vps892.directvps.nl (Postfix, from userid 1008)
	id 2B96E4400AE; Fri,  4 Oct 2019 21:34:06 +0200 (CEST)
Date: Fri, 4 Oct 2019 21:34:06 +0200
From: Kevin Daudt <me@ikke.info>
To: "xrs =:-)" <xrs@mail36.net>
Cc: alpine-aports@lists.alpinelinux.org
Subject: Re: [PATCH 2/4] testing/gnurl: new aport
Message-ID: <20191004193406.GD160327@alpha>
References: <20190928175728.4614-1-xrs@mail36.net>
 <20190928175728.4614-2-xrs@mail36.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190928175728.4614-2-xrs@mail36.net>
User-Agent: Mutt/1.12.1 (2019-06-15)

I have added some feedback inline below.

On Sat, Sep 28, 2019 at 07:57:27PM +0200, xrs =:-) wrote:
> https://gnunet.org/en/gnurl.html
> curl with only HTTP/HTTPS support and GnuTLS
> testing/
> ---
>  testing/gnurl/APKBUILD | 84 ++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 84 insertions(+)
>  create mode 100644 testing/gnurl/APKBUILD
> 
> diff --git a/testing/gnurl/APKBUILD b/testing/gnurl/APKBUILD
> new file mode 100644
> index 0000000000..f8ff73a916
> --- /dev/null
> +++ b/testing/gnurl/APKBUILD
> @@ -0,0 +1,84 @@
> +# Contributor: xrs <xrs@mail36.net>
> +# Maintainer: xrs <xrs@mail36.net>
> +pkgname=gnurl
> +pkgver=7.65.3
> +pkgrel=0
> +pkgdesc="curl with only HTTP/HTTPS support and GnuTLS"
> +url="https://gnunet.org/en/gnurl.html"
> +giturl="git://git.taler.net/gnurl.git"

Any reason you are adding this here? This is normally only used when
using a git repo as the source rather then a source archive.

> +arch="all"
> +license="MIT"
> +depends="ca-certificates gnutls libidn2 zlib"
> +depends_dev="gnutls-dev libidn2-dev zlib-dev"
> +makedepends="$depends_dev autoconf automake libtool perl pkgconf python3"
> +subpackages="$pkgname-dbg $pkgname-dev $pkgname-doc libgnurl"

This package builds a static archive (usr/lib/libgnurl.a). Please either
add `$pkgname-static` to subpackages, or disable building the static
archive (for example sometimes you can add --disable-static to
./configure).

> +source="https://ftp.gnu.org/gnu/gnunet/$pkgname-$pkgver.tar.gz"
> +builddir="$srcdir/$pkgname-$pkgver"
> +
> +prepare() {
> +	default_prepare
> +	cd "$builddir"
> +	autoreconf -vfi
> +}
> +
> +build() {
> +	cd "$builddir"

This is no longer required, and could be removed.

> +		
> +  	./configure \
> +		--build=$CBUILD \
> +		--host=$CHOST \
> +                --with-ca-bundle=/etc/ssl/certs/ca-certificates.crt \

You use mixed tabs and spaced. In aports, the codestyle is to use tabs
everywhere.

> +		--prefix=/usr \
> +		--enable-ipv6 \
> +		--with-gnutls \
> +                --with-libidn2 \
> +		--without-libpsl \
> +		--without-libssh2 \
> +		--without-libmetalink \
> +                --without-winidn \
> +                --without-librtmp \
> +                --without-nghttp2 \
> +                --without-nss \
> +                --without-cyassl \
> +                --without-polarssl \
> +                --without-ssl \
> +                --without-winssl \
> +                --without-darwinssl \
> +                --disable-sspi \
> +                --disable-ntlm-wb \
> +                --disable-ldap \
> +                --disable-rtsp \
> +                --disable-dict \
> +                --disable-telnet \
> +                --disable-tftp \
> +                --disable-pop3 \
> +                --disable-imap \
> +                --disable-smtp \
> +                --disable-gopher \
> +                --disable-file \
> +                --disable-ftp \
> +                --disable-smb \
> +                --disable-ares
> +        make
> +}
> +
> +check() {
> +	cd "$builddir"

This is no longer required, and could be removed.

> +	make -C tests nonflaky-test
> +}
> +
> +package() {
> +	cd "$builddir"

This is no longer required, and could be removed.

> +	make DESTDIR="$pkgdir" install 
> +        #install -Dm644 COPYING "$pkgdir"/usr/share/licenses/$pkgname/COPYING
> +}
> +
> +libgnurl() {
> +	pkgdesc="curl library with only HTTP/HTTPS support and GnuTLS"
> +
> +	mkdir -p "$subpkgdir"/usr
> +	mv "$pkgdir"/usr/lib "$subpkgdir"/usr
> +}
> +
> +
> +sha512sums="51aa71352dfe2e65dbcf542cb616af1eaa7e80fbc4ddb455a338e74eea245724ac1fa7ff226c418101e8ba298a8f85c2be9e7d9190a57c66e2e8c65d0c5186f8  gnurl-7.65.3.tar.gz"
> -- 
> 2.22.0