Received: from vps892.directvps.nl (ikke.info [178.21.113.177])
	by nld3-dev1.alpinelinux.org (Postfix) with ESMTPS id 2F496781AB7
	for <alpine-aports@lists.alpinelinux.org>; Fri,  4 Oct 2019 19:34:25 +0000 (UTC)
Received: by vps892.directvps.nl (Postfix, from userid 1008)
	id F2BD94400AE; Fri,  4 Oct 2019 21:34:24 +0200 (CEST)
Date: Fri, 4 Oct 2019 21:34:24 +0200
From: Kevin Daudt <me@ikke.info>
To: "xrs =:-)" <xrs@mail36.net>
Cc: alpine-aports@lists.alpinelinux.org
Subject: Re: [PATCH 4/4] testing/gnunet-gtk: new aport
Message-ID: <20191004193424.GF160327@alpha>
References: <20190928175728.4614-1-xrs@mail36.net>
 <20190928175728.4614-4-xrs@mail36.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190928175728.4614-4-xrs@mail36.net>
User-Agent: Mutt/1.12.1 (2019-06-15)

I have added some feedback inline.

On Sat, Sep 28, 2019 at 07:57:29PM +0200, xrs =:-) wrote:
> https://gnunet.org
> Graphical user interface for GNUnet
> testing/
> ---
>  testing/gnunet-gtk/APKBUILD | 41 +++++++++++++++++++++++++++++++++++++
>  1 file changed, 41 insertions(+)
>  create mode 100644 testing/gnunet-gtk/APKBUILD
> 
> diff --git a/testing/gnunet-gtk/APKBUILD b/testing/gnunet-gtk/APKBUILD
> new file mode 100644
> index 0000000000..71b12b2372
> --- /dev/null
> +++ b/testing/gnunet-gtk/APKBUILD
> @@ -0,0 +1,41 @@
> +# Contributor: xrs <xrs@mail36.net>
> +# Maintainer: xrs <xrs@mail36.net>
> +pkgname="gnunet-gtk"
> +pkgver="0.11.5"
> +pkgrel=0
> +pkgdesc="Graphical user interface for GNUnet"
> +url="https://gnunet.org"
> +arch="all"
> +license="GPL-3.0"
> +depends="gnunet gtk+3.0 glade"
> +makedepends="gnunet-dev gtk+3.0-dev glade-dev"
> +install=""

Empty variables can be removed.

> +subpackages="$pkgname-dev $pkgname-doc"
> +source="https://mirrors.ocf.berkeley.edu/gnu/gnunet/$pkgname-$pkgver.tar.gz"
> +builddir="$srcdir/$pkgname-$pkgver"
> +options="!check" # The GNUnet project lacks a good CI at the moment. 
> +
> +build() {
> +	cd "$builddir"
> +	./configure \
> +		--build=$CBUILD \
> +		--host=$CHOST \
> +		--prefix=/usr \
> +		--sysconfdir=/etc \
> +		--mandir=/usr/share/man \
> +		--localstatedir=/var \
> +                --disable-fs-app \

Mixed spaces and tabs, use tabs please.

> +                --disable-conversation-app
> +	make
> +}
> +
> +check() {
> +	make DESTDIR="$pkgdir" check
> +        exit 0
> +}
> +
> +package() {
> +	make DESTDIR="$pkgdir" install
> +}
> +
> +sha512sums="8cd5bcadba070396b9b9b4849678bda362ba274f7d8e0c4dfc0bd793ac103a8a94949a472d992c90f21ddb7db16b14ea23a199acd4cf2e52f985e15205d2f5a9  gnunet-gtk-0.11.5.tar.gz"
> -- 
> 2.22.0