Date: Sun, 6 Oct 2019 20:54:35 +0200
From: xrs <xrs@mail36.net>
To: Kevin Daudt <me@ikke.info>
Cc: alpine-aports@lists.alpinelinux.org
Subject: Re: [PATCH 3/4] testing/gnunet: new aport
In-Reply-To: <20191004193416.GE160327@alpha>
References: <20190928175728.4614-1-xrs@mail36.net>
 <20190928175728.4614-3-xrs@mail36.net>
 <20191004193416.GE160327@alpha>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/OosR7tVb_bp+RUpMAlLCXj.";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Message-Id: <20191006185437.948724AAB6@rage.so36.net>

--Sig_/OosR7tVb_bp+RUpMAlLCXj.
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi Kevin,

thanks for your feedback!

On Fri, 4 Oct 2019 21:33:56 +0200
Kevin Daudt <me@ikke.info> wrote:

> Hello xrs,
>=20
> Thanks for your submission! I noticed that libidn2[0] is already in
> aports. so you could drop that. I have given some feedback on the
> other patches. Please fix them and submit them again.
Done. =20

> The package seems to fail to build:
>=20
> > /usr/lib/gcc/x86_64-alpine-linux-musl/9.2.0/../../../../x86_64-alpine-l=
inux-musl/bin/ld:
> > cannot find -lgnunetats
> > collect2: error: ld returned 1 exit status
> > libtool:   error: error: relink
> > 'libgnunet_plugin_ats_proportional.la' with the above command
> > before installing it. =20
>=20
> You can find the complete build log here[0].
>=20
> [0]:https://gitlab.alpinelinux.org/kdaudt/aports/-/jobs/2151

I can't reproduce this on my machine with abuild. uname -a:
Linux 4.19.76-0-vanilla #1-Alpine SMP Thu Oct 3 12:00:48 UTC 2019
x86_64 GNU/Linux
I could ask the GNUnet community but as far as I know this has not been
an issue recently. Any idea?

> Another option is to submit a merge request in our gitlab[2] instance,
> where we have a CI pipeline setup. Here[3] you see the linting output
> for this patch series.
I have no gitlab instance at the moment, thus the "old" way :) Please
have another look at it:
https://lists.alpinelinux.org/~alpine/aports/%3C20191006183040.6456-1-xrs%4=
0mail36.net%3E

Best,
xrs

--Sig_/OosR7tVb_bp+RUpMAlLCXj.
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEXT8kcH87x3rRueqa+SXlGM0N74oFAl2aOGsACgkQ+SXlGM0N
74rqCxAAhh+QDwSIQgwuCgKF8UUv/X7Wik5kFByOvnylT8K2+RKXjZhc9uBa9Iq3
Bhx+1AN7Pdtsi+ldGurBGnDyF4j2zayezuFPVMQQu68tJWg0bFMg/fdB7o694gwi
DR3TZGiS5YSOjR8sx94KLl3NFn/5B3ljKKqvoXJBAeQQelO/ax6HVkyc1J6Ul4jR
zOUboyNYrcwjeSSMI3ns5m2caBn2sAPj6P7P/WXh4rbrCi6Aan10xFQ9YNhIyWmh
2mQlebJxgO9222yyiiHoEwgewA9XL1EwyXTE+BeAmWkMj81lF2p+NbfS9ISU1Hym
N7CdN164VzwA7ZHWTkqbiUq2w1JHrx0ZK2aM4yMqFOrxBc2RJVb4IfuRK5gxyylS
IOmW3iMwQfdW/K/I92Jy3CsdK3FjYQL8XX6pFpg85tOsELCVj6t58OcBLsKephyJ
DDcCEK5TTPccnZfW8abTcid0036tDqE210rWfFf1uH4neOodcq+oHdmVgmY4CSBi
qqA8sA32vyz2iG4ba+8jbFamtRX8y79+yKk+yCoy2zmnWCqXpC7C15Vclry/1zwG
NJ7cFs3vAJ/rEZTUixZJ4jDNIQz7Zi/QFcMRjscIEvmh9AUP0vjWUKEWL6U/8eDz
qKz1rmijKjPN2wRN8FdFbkkhmI5KtebVB6xlNDukP3Etw3Wb16M=
=Vy9r
-----END PGP SIGNATURE-----

--Sig_/OosR7tVb_bp+RUpMAlLCXj.--