Date: Sun, 12 Jan 2020 11:35:31 +0100
From: Leo <thinkabit.ukim@gmail.com>
To: ~alpine/aports@lists.alpinelinux.org
Subject: Re: [PATCH] testing/tiled: new aport
Message-ID: <20200112113531.584802be@enterprise>
In-Reply-To: <20200112093125.18749-1-markand@malikania.fr>
References: <20200112093125.18749-1-markand@malikania.fr>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Sun, 12 Jan 2020 10:31:25 +0100
David Demelier <markand@malikania.fr> wrote:

> http://mapeditor.org
> A powerful tile map editor
> ---
>  testing/tiled/APKBUILD | 33 +++++++++++++++++++++++++++++++++
>  1 file changed, 33 insertions(+)
>  create mode 100644 testing/tiled/APKBUILD
> 
> diff --git a/testing/tiled/APKBUILD b/testing/tiled/APKBUILD
> new file mode 100644
> index 0000000000..09e4875e1e
> --- /dev/null
> +++ b/testing/tiled/APKBUILD
> @@ -0,0 +1,33 @@
> +# Contributor: David Demelier <markand@malikania.fr>
> +# Maintainer: David Demelier <markand@malikania.fr>
> +pkgname="tiled"
> +pkgver="1.3.1"
> +pkgrel=0
> +pkgdesc="A powerful tile map editor"
> +url="http://mapeditor.org"
> +arch="all"
> +license="Apache-2.0 BSD-2-Clause GPL-2.0-only"
> +depends="qt5-qtbase
> +         qt5-qtdeclarative
> +         zlib"

I think only qt5-declarative is required, the others can be removed.

> +makedepends="qt5-qtbase-dev
> +             qt5-qtdeclarative-dev
> +             zlib-dev"

Have them all on the same line, if you really want them on a line each
have 1 tab of indentation.

> +source="${pkgname}-${pkgver}.tar.gz::https://github.com/bjorn/tiled/archive/v${pkgver}.tar.gz"

Unnecessary usage of brackets.

> +builddir="$srcdir/$pkgname-$pkgver"

Default value, can be removed.

> +
> +build() {
> +	qmake-qt5 -r INSTALL_HEADERS=yes PREFIX=/usr
> +	make
> +}
> +
> +check() {
> +	tiled --version
> +}

Have a proper testsuite running or pass options="!check"

> +
> +package() {
> +	make install INSTALL_ROOT="$pkgdir"
> +}
> +
> +sha512sums="b2ed5c0ff043990177809873417e31e8ee2894473b3084d0302e5557c19043c1763cf55d8ade16335ba3d64e7b4b903dd5fb88fd4bcf878c7c4d873bc9c7ed73
>  tiled-1.3.1.tar.gz"