Received: from fx.arvanta.net (static-213-198-238-194.adsl.eunet.rs [213.198.238.194])
	by nld3-dev1.alpinelinux.org (Postfix) with ESMTP id 32C41781AD4
	for <~alpine/aports@lists.alpinelinux.org>; Thu, 30 Jan 2020 22:28:53 +0000 (UTC)
Received: from arya.arvanta.net (arya.arvanta.net [10.5.1.6])
	by fx.arvanta.net (Postfix) with ESMTP id D73CB3E77;
	Thu, 30 Jan 2020 23:28:51 +0100 (CET)
Date: Thu, 30 Jan 2020 23:28:51 +0100
From: Milan =?utf-8?Q?P=2E_Stani=C4=87?= <mps@arvanta.net>
To: ~alpine/aports@lists.alpinelinux.org
Cc: mps@arvanta.net
Subject: Re: [PATCH] main/linux-lts: enable VIRTIO_PCI for armv7
Message-ID: <20200130222851.GA1542@arya.arvanta.net>
References: <20200127185955.5916-1-tobias@waldekranz.com>
 <20200129154459.4909eaa5@ncopa-desktop.copa.dup.pw>
 <20200130214707.GA29092@wkz-x260>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200130214707.GA29092@wkz-x260>

On Thu, 2020-01-30 at 22:47, Tobias Waldekranz wrote:
> On Wed, Jan 29, 2020 at 03:44:59PM +0100, Natanael Copa wrote:
> > On Mon, 27 Jan 2020 19:59:55 +0100
> > Tobias Waldekranz <tobias@waldekranz.com> wrote:
> > 
> > > Among other things, enables using 9p-filesystems with virtio
> > > transport.
> > 
> > There seems to pretty many changes. What are those other things?
> 
> Yes, I'm aware that there's lots of noise here. I believe most of it
> is just due to the fact that many subsystems depend on PCI. E.g. none
> of the NET_VENDOR_ stuff adds any modules to the kernel, it just opens
> up for configuring specific drivers.
> 
> > Do we need pci usb host controller enabled?
> > 
> > Is the pci serial controller needed?
> 
> My method was basically: enable the feature I needed (VIRTIO_PCI) and
> trust the kernel's defaults for the rest. But I agree that there are
> some unnecessary modules here. Would you prefer them to be build as
> loadable modules where possible, or left out completely?

Don't trust kernel defaults. It can enable a lot of unnecessary options
or modules and also disable necessary ones, plus tweak options not
appropriate for distribution kernels.

When posting diffs/patches to distribution do it in small steps and
carefully check if it will not 'interfere' with already enabled/disabled
and current parameters.

> > Would it make more sense to add a linux-virt kernel for armv7 instead?
> > It seems like our aarch64 linux-virt kernel has 9p over virtio.
> 
> That would also work. The aarch64 config has VIRTIO_PCI enabled, but
> unfortunately is missing 9p at the moment. Should I prepare a patch
> set that:
> 
> 1. Enables 9p on aarch64/virt.
> 2. Adds an armv7/virt config.
> Or do you prefer to do it?

If you post your needs/requests I can look at them.
I'm mostly using Alpine on aarch64 and armv7 and I already work to some
additions on both of them, though for now armv7 is priority.

-- 
o/