Date: Thu, 30 Jan 2020 23:00:04 +0100
From: Natanael Copa <ncopa@alpinelinux.org>
To: Tobias Waldekranz <tobias@waldekranz.com>
Cc: alpine-aports@lists.alpinelinux.org
Subject: Re: [PATCH] main/linux-lts: enable VIRTIO_PCI for armv7
Message-ID: <20200130230004.1ebcbc10@ncopa-desktop.copa.dup.pw>
In-Reply-To: <20200130214707.GA29092@wkz-x260>
References: <20200127185955.5916-1-tobias@waldekranz.com>
	<20200129154459.4909eaa5@ncopa-desktop.copa.dup.pw>
	<20200130214707.GA29092@wkz-x260>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 30 Jan 2020 22:47:07 +0100
Tobias Waldekranz <tobias@waldekranz.com> wrote:

> On Wed, Jan 29, 2020 at 03:44:59PM +0100, Natanael Copa wrote:
> > On Mon, 27 Jan 2020 19:59:55 +0100
> > Tobias Waldekranz <tobias@waldekranz.com> wrote:
> >   
> > > Among other things, enables using 9p-filesystems with virtio
> > > transport.  
> > 
> > There seems to pretty many changes. What are those other things?  
> 
> Yes, I'm aware that there's lots of noise here. I believe most of it
> is just due to the fact that many subsystems depend on PCI. E.g. none
> of the NET_VENDOR_ stuff adds any modules to the kernel, it just opens
> up for configuring specific drivers.
> 
> > Do we need pci usb host controller enabled?
> > 
> > Is the pci serial controller needed?  
> 
> My method was basically: enable the feature I needed (VIRTIO_PCI) and
> trust the kernel's defaults for the rest. But I agree that there are
> some unnecessary modules here. Would you prefer them to be build as
> loadable modules where possible, or left out completely?

Would have preferred to remove stuff that will not be used.

>  
> > Would it make more sense to add a linux-virt kernel for armv7 instead?
> > It seems like our aarch64 linux-virt kernel has 9p over virtio.  
> 
> That would also work. The aarch64 config has VIRTIO_PCI enabled, but
> unfortunately is missing 9p at the moment. Should I prepare a patch
> set that:
> 
> 1. Enables 9p on aarch64/virt.
> 2. Adds an armv7/virt config.

I think this makes more sense.
 
> Or do you prefer to do it?

Either way. I could likely have a look at it tomorrow morning so I'll
have a look at it then, unless you beat me to it :)

Thanks!


-nc