Received: from fx.arvanta.net (static-213-198-238-194.adsl.eunet.rs [213.198.238.194])
	by nld3-dev1.alpinelinux.org (Postfix) with ESMTP id EBBFD781A73
	for <~alpine/aports@lists.alpinelinux.org>; Wed, 19 Feb 2020 21:18:17 +0000 (UTC)
Received: from arya.arvanta.net (arya.arvanta.net [10.5.1.6])
	by fx.arvanta.net (Postfix) with ESMTP id BE58027343
	for <~alpine/aports@lists.alpinelinux.org>; Wed, 19 Feb 2020 22:18:16 +0100 (CET)
Date: Wed, 19 Feb 2020 22:18:16 +0100
From: Milan =?utf-8?Q?P=2E_Stani=C4=87?= <mps@arvanta.net>
To: ~alpine/aports@lists.alpinelinux.org
Subject: Re: [PATCH v2] Provide symlinks for lua's .pc files
Message-ID: <20200219211816.GA20696@arya.arvanta.net>
References: <20200219205213.302120-1-wolf@wolfsden.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200219205213.302120-1-wolf@wolfsden.cz>

On Wed, 2020-02-19 at 21:52, Wolf wrote:
> Debian provides multiple aliases for lua's pkg-config package. In
> interest of compatibility, we should do the same. This commit introduces
> symlinks for lua53, lua-5.3, lua52 and lua-5.2 to match what debian
> provides.

Why is Debian compatibility reason for us to follow it?
Please elaborate first and then ask lua maintainer.

> ---
> - Use ${_luaver//./} insteadd of subshell
> - Bump pkgrel
> 
>  main/lua5.2/APKBUILD | 8 ++++++--
>  main/lua5.3/APKBUILD | 8 ++++++--
>  2 files changed, 12 insertions(+), 4 deletions(-)
> 
> diff --git a/main/lua5.2/APKBUILD b/main/lua5.2/APKBUILD
> index e5df917276..f34c3f10fc 100644
> --- a/main/lua5.2/APKBUILD
> +++ b/main/lua5.2/APKBUILD
> @@ -2,7 +2,7 @@
>  pkgname=lua5.2
>  pkgver=5.2.4
>  _luaver=${pkgname#lua}
> -pkgrel=7
> +pkgrel=8
>  pkgdesc="Powerful light-weight programming language"
>  url="https://www.lua.org/"
>  arch="all"
> @@ -119,7 +119,11 @@ Cflags: -I\${includedir}
>  
>  # (end of lua$_luaver.pc)
>  EOF
> -
> +	# lua52.pc   -> lua5.2.pc
> +	ln -s lua$_luaver.pc \
> +		"$pkgdir"/usr/lib/pkgconfig/lua${_luaver//./}.pc
> +	# lua-5.2.pc -> lua5.2.pc
> +	ln -s lua$_luaver.pc "$pkgdir"/usr/lib/pkgconfig/lua-$_luaver.pc
>  }
>  
>  dev() {
> diff --git a/main/lua5.3/APKBUILD b/main/lua5.3/APKBUILD
> index b1baf7b75a..5da074a6a6 100644
> --- a/main/lua5.3/APKBUILD
> +++ b/main/lua5.3/APKBUILD
> @@ -3,7 +3,7 @@ pkgname=lua5.3
>  _pkgname=lua
>  pkgver=5.3.5
>  _luaver=${pkgname#lua}
> -pkgrel=2
> +pkgrel=3
>  pkgdesc="Powerful light-weight programming language"
>  url="https://www.lua.org/"
>  arch="all"
> @@ -120,7 +120,11 @@ package() {
>  
>  		# (end of lua$_luaver.pc)
>  	EOF
> -
> +	# lua53.pc   -> lua5.3.pc
> +	ln -s lua$_luaver.pc \
> +		"$pkgdir"/usr/lib/pkgconfig/lua${_luaver//./}.pc
> +	# lua-5.3.pc -> lua5.3.pc
> +	ln -s lua$_luaver.pc "$pkgdir"/usr/lib/pkgconfig/lua-$_luaver.pc
>  }
>  
>  dev() {
> -- 
> 2.25.0