Received: from fx.arvanta.net (static-213-198-238-194.adsl.eunet.rs [213.198.238.194])
	by nld3-dev1.alpinelinux.org (Postfix) with ESMTP id DD506781A9F
	for <~alpine/aports@lists.alpinelinux.org>; Fri, 28 Feb 2020 11:03:57 +0000 (UTC)
Received: from arya.arvanta.net (arya.arvanta.net [10.5.1.6])
	by fx.arvanta.net (Postfix) with ESMTP id D39323DFB
	for <~alpine/aports@lists.alpinelinux.org>; Fri, 28 Feb 2020 12:03:56 +0100 (CET)
Date: Fri, 28 Feb 2020 12:03:56 +0100
From: Milan =?utf-8?Q?P=2E_Stani=C4=87?= <mps@arvanta.net>
To: ~alpine/aports@lists.alpinelinux.org
Subject: Re: [PATCH] testing/presto: new aport
Message-ID: <20200228110356.GA26678@arya.arvanta.net>
References: <20200228105112.8193-1-suiwenfeng@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200228105112.8193-1-suiwenfeng@gmail.com>

Hello suiwenfeng,

This looks like binary package and not source. As such it is not
acceptable for inclusion in Alpine Linux.

-- 
regards

On Fri, 2020-02-28 at 10:51, suiwenfeng wrote:
> https://prestodb.io/docs/current/installation/cli.html
> Presto CLI
> ---
>  testing/presto/APKBUILD            | 28 ++++++++++++++++++++++++++++
>  testing/presto/presto.post-install |  5 +++++
>  2 files changed, 33 insertions(+)
>  create mode 100644 testing/presto/APKBUILD
>  create mode 100644 testing/presto/presto.post-install
> 
> diff --git a/testing/presto/APKBUILD b/testing/presto/APKBUILD
> new file mode 100644
> index 0000000000..f0fae5407d
> --- /dev/null
> +++ b/testing/presto/APKBUILD
> @@ -0,0 +1,28 @@
> +# Contributor: suiwenfeng <suiwenfeng@gmail.com>
> +# Maintainer: suiwenfeng <suiwenfeng@gmail.com>
> +pkgname="presto"
> +pkgver="0.232"
> +pkgrel=0
> +pkgdesc="Presto CLI"
> +url="https://prestodb.io/docs/current/installation/cli.html"
> +arch="all"
> +license="MIT"
> +depends="openjdk8-jre"
> +install="$pkgname.post-install"
> +builddir="$srcdir/"
> +
> +build() {
> +	echo "building success"
> +}
> +
> +check() {
> +	echo "checking success"
> +}
> +
> +package() {
> +	wget "https://repo1.maven.org/maven2/com/facebook/presto/presto-cli/$pkgver/presto-cli-$pkgver-executable.jar"
> +	mkdir -p "$pkgdir/usr/bin"
> +	mv "$srcdir/presto-cli-$pkgver-executable.jar" "$pkgdir/usr/bin/presto"
> +	sudo chmod +x "$pkgdir/usr/bin/presto"
> +}
> +
> diff --git a/testing/presto/presto.post-install b/testing/presto/presto.post-install
> new file mode 100644
> index 0000000000..e9d798569d
> --- /dev/null
> +++ b/testing/presto/presto.post-install
> @@ -0,0 +1,5 @@
> +#!/bin/sh
> +
> +echo -e "please \e[1;31mexport PRESTO_PAGER=more\e[0m before using it"
> +
> +exit 0
> -- 
> 2.24.1