Received: from mx1.tetrasec.net (mx1.tetrasec.net [66.245.176.36])
	by nld3-dev1.alpinelinux.org (Postfix) with ESMTPS id BF1A9782C74
	for <~alpine/aports@lists.alpinelinux.org>; Mon, 30 Mar 2020 11:50:55 +0000 (UTC)
Received: from mx1.tetrasec.net (mail.local [127.0.0.1])
	by mx1.tetrasec.net (Postfix) with ESMTP id 2F43864C96
	for <~alpine/aports@lists.alpinelinux.org>; Mon, 30 Mar 2020 11:50:55 +0000 (UTC)
Received: from ncopa-desktop.copa.dup.pw (67.63.200.37.customer.cdi.no [37.200.63.67])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256)
	(No client certificate requested)
	(Authenticated sender: alpine@tanael.org)
	by mx1.tetrasec.net (Postfix) with ESMTPSA id A155D64C95
	for <~alpine/aports@lists.alpinelinux.org>; Mon, 30 Mar 2020 11:50:54 +0000 (UTC)
Date: Mon, 30 Mar 2020 13:50:51 +0200
From: Natanael Copa <ncopa@alpinelinux.org>
To: ~alpine/aports@lists.alpinelinux.org
Subject: Re: [PATCH] testing/hatop: new aport
Message-ID: <20200330135051.15766c2d@ncopa-desktop.copa.dup.pw>
In-Reply-To: <20200330000515.46364-1-mail@gjnoonan.co.uk>
References: <20200330000515.46364-1-mail@gjnoonan.co.uk>
X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-alpine-linux-musl)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Mon, 30 Mar 2020 01:05:15 +0100
Gavin-John Noonan <mail@gjnoonan.co.uk> wrote:

> Signed-off-by: Gavin-John Noonan <mail@gjnoonan.co.uk>
> ---
>  testing/hatop/APKBUILD | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
>  create mode 100644 testing/hatop/APKBUILD
> 
> diff --git a/testing/hatop/APKBUILD b/testing/hatop/APKBUILD
> new file mode 100644
> index 000000000000..372f34b28892
> --- /dev/null
> +++ b/testing/hatop/APKBUILD
> @@ -0,0 +1,24 @@
> +# Contributor: Gavin-John Noonan <mail@gjnoonan.co.uk>
> +# Maintainer: Gavin-John Noonan <mail@gjnoonan.co.uk>
> +pkgname="hatop"
> +pkgver="0.7.7"
> +pkgrel=0
> +pkgdesc="Interactive ncurses client for the HAProxy unix socket"
> +url="https://github.com/jhunt/hatop"
> +arch="noarch"
> +license="GPLv3"
> +depends="python2 haproxy"

I don't think we should introduce new packages that uses python2. Can
this use python3? if not, can you please report it upstream?

Thanks!

-nc


> +options="!check" # No test suite
> +subpackages="$pkgname-doc"
> +source="$pkgname-$pkgver.tar.gz::https://github.com/jhunt/hatop/archive/v$pkgver.tar.gz"
> +builddir="$srcdir/"
> +
> +package() {
> +	install -Dm755 "$pkgname-$pkgver/bin/hatop" \
> +		"$pkgdir/usr/bin/hatop"
> +	install -Dm644 "$pkgname-$pkgver/man/hatop.1" \
> +		"$pkgdir/usr/share/man/man1/hatop.1"
> +
> +}
> +
> +sha512sums="d678caf9f98ff4a800af120c0f06ffb842f55747486050070b2096526fda16e6e009d47e4cd6237ad3de2cf69732ebf5f29eba0dd84098e27ddc90f3a51212d6  hatop-0.7.7.tar.gz"