Date: Wed, 22 Jul 2020 05:12:40 -0300
From: Leo <thinkabit.ukim@gmail.com>
To: ~alpine/aports@lists.alpinelinux.org
Subject: Re: [PATCH] testing/mediastreamer2-plugin-x264: new aport
Message-ID: <20200722051240.78110e52@enterprise>
In-Reply-To: <20200722075927.8449-1-martin.schmidt13@gmx.de>
References: <20200722075927.8449-1-martin.schmidt13@gmx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 22 Jul 2020 09:59:27 +0200
Martin Schmidt <martin.schmidt13@gmx.de> wrote:

> This hopefully gives us video in linphonec.
> ---
>  testing/mediastreamer2-plugin-x264/APKBUILD | 37
> +++++++++++++++++++++ 1 file changed, 37 insertions(+)
>  create mode 100644 testing/mediastreamer2-plugin-x264/APKBUILD
> 
> diff --git a/testing/mediastreamer2-plugin-x264/APKBUILD
> b/testing/mediastreamer2-plugin-x264/APKBUILD new file mode 100644
> index 0000000000..159ac84f0e
> --- /dev/null
> +++ b/testing/mediastreamer2-plugin-x264/APKBUILD
> @@ -0,0 +1,37 @@
> +pkgname=mediastreamer2-plugin-x264
> +pkgver=20200721
> +pkgrel=0
> +pkgdesc="GPL plugin to bring video H264 encoding/decoding
> capabilities to mediastreamer2 applications"
> +url="https://gitlab.linphone.org/BC/public/msx264" 
> +arch="all"
> +license="GPL-2.0-or-later"
> +options="!check" # no test available
> +makedepends="cmake ortp-dev x264-dev"
> +
> +source="https://gitlab.linphone.org/BC/public/msx264/-/archive/master/msx264-master.tar.gz"

Please use a versioned archive, if upstream makes new commits then the
generated .tar.gz will change and the build will fail too.

> +
> +builddir="$srcdir/msx264-master"
> +
> +build() {
> +
> +	sed -i 's/ORTP\ REQUIRED/ortp\ REQUIRED/g' src/CMakeLists.txt

Please have it in prepare() like this:

```sh
prepare() {
    default_prepare

   sed -i 's/ORTP\ REQUIRED/ortp\ REQUIRED/g' src/CMakeLists.txt
}
```

> +
> +	cmake -B build \
> +		-DCMAKE_BUILD_TYPE=None \
> +		-DCMAKE_INSTALL_PREFIX=/usr \
> +		-DCMAKE_INSTALL_LIBDIR=lib \
> +		-DCMAKE_MODULE_PATH=/usr/lib/cmake \
> +		-DCMAKE_SKIP_INSTALL_RPATH=ON \
> +		-DENABLE_STRICT=NO \
> +		-DENABLE_SHARED=YES
> +
> +	make  -C build
> +}
> +
> +package() {
> +
> +	make -C build DESTDIR="$pkgdir" install
> +}
> +
> +
> +sha512sums="2f16624dcdbeea10eaf257d524e862b4db5f559189554d22f72696c6fbb99a8382bdc75e13b826c9468464412dedc101bbe57dd2d0e13eb6d7223de310d4ed52
>  msx264-master.tar.gz" --
> 2.27.0

Also please open a merge request on
gitlab.alpinelinux.org/alpine/aports so we can use CI