Date: Thu, 17 Sep 2020 20:20:01 -0300
From: Leo <thinkabit.ukim@gmail.com>
To: ~alpine/aports@lists.alpinelinux.org
Subject: Re: [PATCH] testing/djvulibre: new aport
Message-ID: <20200917202001.1db882e6@enterprise>
In-Reply-To: <20200917222251.25793-1-fukanchik@gmail.com>
References: <20200917222251.25793-1-fukanchik@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 17 Sep 2020 22:22:51 +0000
Sergey Fukanchik <fukanchik@gmail.com> wrote:

> http://djvu.sourceforge.net/
> Utilities and Libraries for the DjVu image format
> ---
>  testing/djvulibre/APKBUILD | 60
> ++++++++++++++++++++++++++++++++++++++ 1 file changed, 60
> insertions(+) create mode 100644 testing/djvulibre/APKBUILD
> 
> diff --git a/testing/djvulibre/APKBUILD b/testing/djvulibre/APKBUILD
> new file mode 100644
> index 0000000000..9c73ff2ead
> --- /dev/null
> +++ b/testing/djvulibre/APKBUILD
> @@ -0,0 +1,60 @@
> +# Contributor: Sergey Fukanchik <fukanchik@gmail.com>
> +pkgname=djvulibre
> +pkgver=3.5.27
> +pkgrel=0
> +pkgdesc="Utilities and Libraries for the DjVu image format"
> +url="http://djvu.sourceforge.net/"
> +arch="all"
> +license="GPL-2.0"

Please use the SPDX license identifier, this is missing '-or-later' or
'-only'

> +depends="libjpeg-turbo tiff"

Shouldn't be necessary, abuild will automatically detect which
libraries an ELF file needs.

> +makedepends="libjpeg-turbo-dev tiff-dev"
> +subpackages="$pkgname-bin:_bin $pkgname-desktop $pkgname-text
> $pkgname-dev $pkgname-doc lib$pkgname:libs"

we generally use $pkgname-libs

> +source="http://downloads.sourceforge.net/djvu/djvulibre-$pkgver.tar.gz"
> + +build() {
> +	./configure \
> +		--build=$CBUILD \
> +		--host=$CHOST \
> +		--prefix=/usr \
> +		--mandir=/usr/share/man
> +
> +	make
> +}
> +
> +_bin() {
> +	pkgdesc="Utilities for the DjVu image format"
> +	mkdir -p "$subpkgdir"/usr
> +	mv "$pkgdir"/usr/bin "$subpkgdir"/usr
> +}
> +
> +libs() {
> +	pkgdesc="Runtime support for the DjVu image format"
> +	mkdir -p "$subpkgdir"/usr/lib
> +	mv "$pkgdir"/usr/lib/*.so.* \
> +		"$subpkgdir"/usr/lib/
> +}
> +
> +text() {
> +	pkgdesc="Linguistic support files for libdjvulibre"
> +	mkdir -p "$subpkgdir"/usr/share/
> +	mv "$pkgdir"/usr/share/djvu \
> +		"$subpkgdir"/usr/share/
> +}
> +
> +desktop() {
> +	pkgdesc="Desktop support for the DjVu image format"
> +	mkdir -p "$subpkgdir"/usr/share
> +	mv "$pkgdir"/usr/share/mime \
> +		"$pkgdir"/usr/share/icons \
> +		"$subpkgdir"/usr/share/
> +}
> +
> +check() {
> +	make check
> +}
> +
> +package() {
> +	make DESTDIR="$pkgdir" install
> +}
> +
> +sha512sums="62abcaa2fe7edab536477929ba38b882453dab1a06e119a3f838b38d5c61f5d8c252e4769e6534582b826e49bcfb490513179580fab9c3afa84aa92053ccebee
>  djvulibre-3.5.27.tar.gz"


Please have the subpackage functions after package() and open a Merge
Request on gitlab.alpinelinux.org/alpine/aports