Received: from fx.arvanta.net (static-213-198-238-194.adsl.eunet.rs [213.198.238.194])
	by nld3-dev1.alpinelinux.org (Postfix) with ESMTP id 77A5378196D
	for <~alpine/aports@lists.alpinelinux.org>; Wed, 14 Oct 2020 10:04:23 +0000 (UTC)
Received: from arya.arvanta.net (arya.arvanta.net [10.5.1.6])
	by fx.arvanta.net (Postfix) with ESMTP id B28E415E7F
	for <~alpine/aports@lists.alpinelinux.org>; Wed, 14 Oct 2020 12:04:22 +0200 (CEST)
Date: Wed, 14 Oct 2020 12:04:22 +0200
From: Milan =?utf-8?Q?P=2E_Stani=C4=87?= <mps@arvanta.net>
To: ~alpine/aports@lists.alpinelinux.org
Subject: Re: [PATCH] testing/tre: new aport
Message-ID: <20201014100422.GA16738@arya.arvanta.net>
References: <20201014080446.15248-1-alhassanaraouf@disroot.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201014080446.15248-1-alhassanaraouf@disroot.org>

Hi,

I tried to build it as it is posted but it fail.
Maybe consider using version from https://github.com/laurikari/tre/

On Wed, 2020-10-14 at 10:04, Al-Hassan Abdel-Raouf wrote:
> https://laurikari.net/tre
> POSIX compliant regexp matching library.
> Includes agrep for approximate grepping.
> ---
>  testing/tre/APKBUILD | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
>  create mode 100644 testing/tre/APKBUILD
> 
> diff --git a/testing/tre/APKBUILD b/testing/tre/APKBUILD
> new file mode 100644
> index 0000000000..4eb0e68fe4
> --- /dev/null
> +++ b/testing/tre/APKBUILD
> @@ -0,0 +1,25 @@
> +# Contributor:
> +# Maintainer:

It is not good idea to introduce package if no one intend to maintain
it.

> +pkgname=tre
> +pkgver=0.8.0
> +pkgrel=0
> +pkgdesc="POSIX compliant regexp matching library. Includes agrep for approximate grepping."
> +url="https://laurikari.net/tre"
> +arch="all"
> +license="BSD"
> +depends="musl"
            ^^^^
This is not needed, it is by default.

> +subpackages="$pkgname-doc $pkgname-dev"
> +source="https://laurikari.net/tre/tre-$pkgver.tar.bz2"
> +
> +build() {
> +	cd "$srcdir/$pkgname-$pkgver"
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Also this is not needed, it is default
> + 	./configure --prefix=/usr --enable-static
> +	make

Keep these two aligned, i.e. equally indented
> +}
> +
> +package() {
> +	make DESTDIR="$pkgdir" install
> +
> +}
> +
> +sha512sums="db7465993e0d25eee8e52f974427b8a040234cf0f017769eb94ee88bc6261821336aad7f762bfa82db7e2212d8449bc221592586f061c528a59a550773cbc263  tre-0.8.0.tar.bz2"
> -- 
> 2.28.0