Date: Wed, 14 Oct 2020 14:22:44 -0300
From: Leo <thinkabit.ukim@gmail.com>
To: ~alpine/aports@lists.alpinelinux.org
Subject: Re: [PATCH v2] testing/tre: new aport
Message-ID: <20201014142244.1b04260f@enterprise>
In-Reply-To: <20201014133001.11101-1-alhassanaraouf@disroot.org>
References: <20201014133001.11101-1-alhassanaraouf@disroot.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Wed, 14 Oct 2020 15:30:01 +0200
Al-Hassan Abdel-Raouf <alhassanaraouf@disroot.org> wrote:

> https://laurikari.net/tre
> POSIX compliant regexp matching library.
> Includes agrep for approximate grepping.
> ---
>  testing/tre/APKBUILD | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
>  create mode 100644 testing/tre/APKBUILD
> 
> diff --git a/testing/tre/APKBUILD b/testing/tre/APKBUILD
> new file mode 100644
> index 0000000000..eddfb91bd3
> --- /dev/null
> +++ b/testing/tre/APKBUILD
> @@ -0,0 +1,22 @@
> +# Contributor:
> +# Maintainer:

Why no Maintainer ?

> +pkgname=tre
> +pkgver=0.8.0
> +pkgrel=0
> +pkgdesc="POSIX compliant regexp matching library. Includes agrep for
> approximate grepping." +url="https://laurikari.net/tre"
> +arch="all"
> +license="BSD"

Need to use an SPDX identifier

> +subpackages="$pkgname-doc $pkgname-dev"
> +source="https://laurikari.net/tre/tre-$pkgver.tar.bz2"
> +
> +build() {
> +	./configure --prefix=/usr --enable-static

Please also pass --build=$CBUILD and --host=$CHOST

> +	make
> +}
> +
> +package() {
> +	make DESTDIR="$pkgdir" install
> +}
> +
> +sha512sums="db7465993e0d25eee8e52f974427b8a040234cf0f017769eb94ee88bc6261821336aad7f762bfa82db7e2212d8449bc221592586f061c528a59a550773cbc263
>  tre-0.8.0.tar.bz2"