Received: from knopi.disroot.org (knopi.disroot.org [178.21.23.139]) by nld3-dev1.alpinelinux.org (Postfix) with ESMTPS id 06E34782C3B for ; Tue, 8 Jun 2021 13:33:36 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id AA8705BE0A for ; Tue, 8 Jun 2021 15:33:35 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with UTF8SMTP id hcvxeYBarCdu for ; Tue, 8 Jun 2021 15:33:34 +0200 (CEST) Date: Tue, 8 Jun 2021 20:33:18 +0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1623159202; bh=/YbUuGrwJr5+njVXSgv0b1gcGDGEW1Fi9yqEhwkr62o=; h=Date:From:To:Subject:References:In-Reply-To; b=K4qa0rJTzqJUFcaYX3jp/BEbGXbVidWuFSyWKbMPCJBY4kCoqXwtfGBCmQT7UTONq xsNHd5n4h78O8haOhJHEfVx0Y1a65CWPAUcJB+kgDpAJhjoM0PWPpbeQuK9GLS1dtZ 6sozsEQopiua5Xj1tUzUOVtx5FsP0nPahQS8q7wile27PYoW0hr5MCg1SXN2R9rrZn Oag8/t/AQkCkrdA4o4Py7QmG/8d7dlxOj4eq2p7vokYxOIxZ9Yc3IGn4nLJ8UZ2i3L wv9a/RhYJFvRDjpjNCKLfBMZTpCDyiJWX9LKDf5xcnNOvvyWxj1UUEMm3UoPcLf7+S CoaPc/etzuoNw== From: =?utf-8?B?TmfDtCBOZ+G7jWMgxJDhu6lj?= Huy To: alpine-aports@lists.alpinelinux.org Subject: Re: [PATCH v5] testing/dictd: new aport Message-ID: <20210608133318.itqxqftirlhcmgh4@localhost.localdomain> References: <20210608131014.10389-1-huyngo@disroot.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Disposition: inline In-Reply-To: <20210608131014.10389-1-huyngo@disroot.org> I also noticed some problems with this patch: - The ARM builds failed, though I don't know the reason. I will exclude those architectures from the next patch if needed. - The build does not run tests yet. I'm not clear how the tests are run, and the upstream maintainer said he would test it himself. - `rc-service dictd start` isn't working yet, because there is no dictionaries in `/usr/share/dict/` yet. If you want to test it, you can download a dictionary from a repo I created [0]. [0]: https://github.com/Huy-Ngo/dictd-dictionaries/tree/ubuntu-dicts/build