~alpine/aports

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
7 4

[PATCH] testing/acme-client: use release tarball

Details
Message ID
<20210711001253.753410-1-wolf@wolfsden.cz>
DKIM signature
missing
Download raw message
Patch: +4 -9
---
 testing/acme-client/APKBUILD | 13 ++++---------
 1 file changed, 4 insertions(+), 9 deletions(-)

diff --git a/testing/acme-client/APKBUILD b/testing/acme-client/APKBUILD
index 595867bfcc..27eaac64f1 100644
--- a/testing/acme-client/APKBUILD
+++ b/testing/acme-client/APKBUILD
@@ -1,7 +1,6 @@
# Contributor: Jordan Christiansen <xordspar0@gmail.com>
# Maintainer: Jordan Christiansen <xordspar0@gmail.com>
pkgname=acme-client
_reponame=acme-client-portable
pkgver=1.2.0
pkgrel=0
pkgdesc="Client for issuing certificates from ACME-complaint servers"
@@ -10,15 +9,9 @@ arch="all"
license="ISC"
makedepends="openssl-dev byacc automake autoconf"
subpackages="$pkgname-doc"
source="$pkgname-v$pkgver.tar.gz::https://git.sr.ht/~graywolf/$_reponame/archive/v$pkgver.tar.gz"
builddir="$srcdir/$_reponame-v$pkgver"
source="https://data.wolfsden.cz/sources/acme-client-$pkgver.tar.gz"
options="!check" # Upstream has no tests.

prepare() {
	default_prepare
	autoreconf -fi
}

build() {
	./configure \
		--build=$CBUILD \
@@ -34,4 +27,6 @@ package() {
	make DESTDIR="$pkgdir" install
}

sha512sums="c4cef43bca99516296271380680181b15a3be50b15c4af7297508d5b09dd07ba03614c88cca2b944fcb8739ca0178f8f90fd2e999d349a684059e32d5d18586b  acme-client-v1.2.0.tar.gz"
sha512sums="
205e89c700aa97b661a9adcb6fadbd804ffb216d80fea7cd31aeda73e780db9312159983376cb0d3f87309d0cc9015dd384e75147d5cf126ef872297fe05a38d  acme-client-1.2.0.tar.gz
"
-- 
2.32.0
Details
Message ID
<162600777914.6885.6733075309129603844.gitlab.23024.cb2dc51db5d71a526dfa1661ca368601feac66cb@listserv.local>
In-Reply-To
<20210711001253.753410-1-wolf@wolfsden.cz> (view parent)
DKIM signature
missing
Download raw message
needs bump pkgrel

-- 
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/23024#note_167634
Details
Message ID
<20210711125241.kvupab66vlz5ftey@wolfsden.cz>
In-Reply-To
<162600777914.6885.6733075309129603844.gitlab.23024.cb2dc51db5d71a526dfa1661ca368601feac66cb@listserv.local> (view parent)
DKIM signature
missing
Download raw message
On 2021-07-11 12:49:39 -0000, Andy Postnikov wrote:
> needs bump pkgrel

I can send v2 but out of curiosity why? It is the exact same source code
so there should be no need to rebuild.

W.

-- 
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.
Details
Message ID
<162600796512.6885.3344329717848913474.gitlab.23024.cb2dc51db5d71a526dfa1661ca368601feac66cb@listserv.local>
In-Reply-To
<162600777914.6885.6733075309129603844.gitlab.23024.cb2dc51db5d71a526dfa1661ca368601feac66cb@listserv.local> (view parent)
DKIM signature
missing
Download raw message
Wolf <wolf@wolfsden.cz> replied via email:

```
On 2021-07-11 12:49:39 -0000, Andy Postnikov wrote:
> needs bump pkgrel

I can send v2 but out of curiosity why? It is the exact same source code
so there should be no need to rebuild.

W.

-- 
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.

```

-- 
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/23024#note_167636
Details
Message ID
<162602829233.6885.3498787333085363508.gitlab.23024.cb2dc51db5d71a526dfa1661ca368601feac66cb@listserv.local>
In-Reply-To
<162600796512.6885.3344329717848913474.gitlab.23024.cb2dc51db5d71a526dfa1661ca368601feac66cb@listserv.local> (view parent)
DKIM signature
missing
Download raw message
Hi! 

Without a `pkgrel` bump, the builders won't pick it up :)

-- 
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/23024#note_167656
Details
Message ID
<20210712010302.pfwnaogtn7mrmc3p@wolfsden.cz>
In-Reply-To
<162602829233.6885.3498787333085363508.gitlab.23024.cb2dc51db5d71a526dfa1661ca368601feac66cb@listserv.local> (view parent)
DKIM signature
missing
Download raw message
On 2021-07-11 18:31:32 -0000, Dylan Van Assche wrote:
> Without a `pkgrel` bump, the builders won't pick it up :)

My point was that I do not think that they have to pick it up since
nothing was actually changed, it is still the same version. So I thought
that rebuild would be just waste of computer time. But v2 was sent which
includes the pkgrel bump, maybe it's cleaner this way.

W.

-- 
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.
Details
Message ID
<162605178675.6885.4773050190248809.gitlab.23024.cb2dc51db5d71a526dfa1661ca368601feac66cb@listserv.local>
In-Reply-To
<162602829233.6885.3498787333085363508.gitlab.23024.cb2dc51db5d71a526dfa1661ca368601feac66cb@listserv.local> (view parent)
DKIM signature
missing
Download raw message
Wolf <wolf@wolfsden.cz> replied via email:

```
On 2021-07-11 18:31:32 -0000, Dylan Van Assche wrote:
> Without a `pkgrel` bump, the builders won't pick it up :)

My point was that I do not think that they have to pick it up since
nothing was actually changed, it is still the same version. So I thought
that rebuild would be just waste of computer time. But v2 was sent which
includes the pkgrel bump, maybe it's cleaner this way.

W.

-- 
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.

```

-- 
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/23024#note_167685
Details
Message ID
<162608682559.6885.1053972441677796036.gitlab.23024.6d4d5dc0e4e29ca53eedcf0cf75401fbc89a4cd1@listserv.local>
In-Reply-To
<20210711001253.753410-1-wolf@wolfsden.cz> (view parent)
DKIM signature
missing
Download raw message
Merged as https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/23048

-- 
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/23024#note_167731
Reply to thread Export thread (mbox)