~alpine/aports

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
7 2

[PATCH] community/read-it-later: new aport

Alistair Francis <alistair@alistair23.me>
Details
Message ID
<20210801084549.314-1-alistair@alistair23.me>
DKIM signature
missing
Download raw message
2 years ago
Patch: +25 -0 
Signed-off-by: Alistair Francis <alistair@alistair23.me>
---
 community/read-it-later/APKBUILD | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)
 create mode 100755 community/read-it-later/APKBUILD

diff --git a/community/read-it-later/APKBUILD b/community/read-it-later/APKBUILD
new file mode 100755
index 0000000000..6d6ffe58bc
--- /dev/null
+++ b/community/read-it-later/APKBUILD
@@ -0,0 +1,25 @@
# Contributor: Alistair Francis <alistair@alistair23.me>
# Maintainer: Alistair Francis <alistair@alistair23.me>
pkgname=read-it-later
pkgver=0.0.2
pkgrel=0
pkgdesc="A Wallabag Client built with GTK"
url="https://gitlab.gnome.org/World/read-it-later"
arch="all !s390x !mips64 !riscv64" # cargo, rust not found
license="GPL-3.0-only"
makedepends="meson bash rust cargo webkit2gtk-dev libhandy-dev sqlite-dev gettext-dev openssl-dev"
source="read-it-later-$pkgver.tar.gz::https://gitlab.gnome.org/World/read-it-later/-/archive/$pkgver/read-it-later-$pkgver.tar.gz"
options="!check" # no tests
builddir="$srcdir/read-it-later-$pkgver"

build() {
	export RUSTC_BOOTSTRAP=obfstr
	abuild-meson . output
	meson compile -j 2 -C output
}

package() {
	DESTDIR="$pkgdir" meson install --no-rebuild -C output
}

sha512sums="fce6d6896e434793c03b65c9f960a3006af807084cbc1538a3e1324e2b1aac22ffb284e41e8a4ee94c533cd3cb900256cbf65c97f5e61e6b0938566d2850e459  read-it-later-0.0.2.tar.gz"
-- 
2.31.1
Ariadne Conill <no-reply@dispatch.alpinelinux.org>
Details
Message ID
<162780786861.6885.8735770266943065454.gitlab.23782.fa0b40809ab36a0b7e233758159f6e0b7b494e39@listserv.local>
In-Reply-To
<20210801084549.314-1-alistair@alistair23.me> (view parent)
DKIM signature
missing
Download raw message
2 years ago 
New packages must enter `testing` first.  Please move to `testing`.

-- 
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/23782#note_171213
Ariadne Conill <no-reply@dispatch.alpinelinux.org>
Details
Message ID
<162780791793.6885.12347721916359577303.gitlab.23782.58293c04e6ea3d534541e1ffd22fa1133155f8a3@listserv.local>
In-Reply-To
<20210801084549.314-1-alistair@alistair23.me> (view parent)
DKIM signature
missing
Download raw message
2 years ago 
On Sun, 01 Aug 2021 18:45:49 +1000, Alistair Francis wrote:
> +source="read-it-later-$pkgver.tar.gz::https://gitlab.gnome.org/World/read-it-later/-/archive/$pkgver/read-it-later-$pkgver.tar.gz"
> +options="!check" # no tests
> +builddir="$srcdir/read-it-later-$pkgver"

You can delete this, the default `$builddir` will be correct.

-- 
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/23782#note_171214
Ariadne Conill <no-reply@dispatch.alpinelinux.org>
Details
Message ID
<162780793443.6885.1055502928784601048.gitlab.23782.92167b167acf8009001b3923f5fe71d601dfd62a@listserv.local>
In-Reply-To
<20210801084549.314-1-alistair@alistair23.me> (view parent)
DKIM signature
missing
Download raw message
2 years ago 
On Sun, 01 Aug 2021 18:45:49 +1000, Alistair Francis wrote:
> +
> +build() {
> +	export RUSTC_BOOTSTRAP=obfstr

why?

-- 
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/23782#note_171215
Ariadne Conill <no-reply@dispatch.alpinelinux.org>
Details
Message ID
<162780808696.6885.13202870264849566078.gitlab.23782.1b02677460053ce133683298f9b756f4153cf201@listserv.local>
In-Reply-To
<20210801084549.314-1-alistair@alistair23.me> (view parent)
DKIM signature
missing
Download raw message
2 years ago 
On Sun, 01 Aug 2021 18:45:49 +1000, Alistair Francis wrote:
> +url="https://gitlab.gnome.org/World/read-it-later"
> +arch="all !s390x !mips64 !riscv64" # cargo, rust not found
> +license="GPL-3.0-only"

Where do you conclude it is `GPL-3.0-only`?  GNOME things are almost always `GPL-3.0-or-later`.

-- 
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/23782#note_171216
Ariadne Conill <no-reply@dispatch.alpinelinux.org>
Details
Message ID
<162780811129.6885.1597145561870823214.gitlab.23782.5a6f62f94f341b632bf22d9b884fc8b674a8378e@listserv.local>
In-Reply-To
<20210801084549.314-1-alistair@alistair23.me> (view parent)
DKIM signature
missing
Download raw message
2 years ago 
Some minor nitpicks, but otherwise looks good once the `testing` change is done.

-- 
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/23782#note_171217
Alistair Francis <no-reply@dispatch.alpinelinux.org>
Details
Message ID
<162785728453.6885.12262706412590193268.gitlab.23782.1b02677460053ce133683298f9b756f4153cf201@listserv.local>
In-Reply-To
<162780808696.6885.13202870264849566078.gitlab.23782.1b02677460053ce133683298f9b756f4153cf201@listserv.local> (view parent)
DKIM signature
missing
Download raw message
2 years ago 
On Sun, 01 Aug 2021 18:45:49 +1000, Alistair Francis wrote:
> +url="https://gitlab.gnome.org/World/read-it-later"
> +arch="all !s390x !mips64 !riscv64" # cargo, rust not found
> +license="GPL-3.0-only"

It doesn't seem to indicate "or later" at https://gitlab.gnome.org/World/read-it-later/-/blob/master/LICENSE.md

-- 
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/23782#note_171303
Alistair Francis <no-reply@dispatch.alpinelinux.org>
Details
Message ID
<162794007102.6885.9692130532214317697.gitlab.23782.7d3c717e03adc38c7c564fbfc26c5d165b2a3778@listserv.local>
In-Reply-To
<20210801084549.314-1-alistair@alistair23.me> (view parent)
DKIM signature
missing
Download raw message
2 years ago 
Thanks for the review. This has been replaced with https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/23831

-- 
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/23782#note_171512
Reply to thread Export thread (mbox)