Received: from ncopa-desktop.lan (67.63.200.37.customer.cdi.no [37.200.63.67])
	(Authenticated sender: ncopa@alpinelinux.org)
	by nld3-dev1.alpinelinux.org (Postfix) with ESMTPSA id EAFDA780E85;
	Thu, 25 Nov 2021 13:24:21 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alpinelinux.org;
	s=smtp; t=1637846662;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=sRmaGlKh3J/HMsu1ZLg1VPrwplMdyCYLKLYpJrSML00=;
	b=JMZ4yPJ/nX7oncv9qfvjXffatwSew9vJmpzYZRNCnq2NtCEfNaJXVjE1pUCZmFSmye81Wd
	CAOuaJ6jfGdQsB83vLzZq8gXybJZ810wFe7kXSnYjqhuRotnDBC+itmQNk5bHUHi2gtybH
	03txZ2z+yQVCBYkz/f9JwJIDgNluzuc=
Date: Thu, 25 Nov 2021 14:24:18 +0100
From: Natanael Copa <ncopa@alpinelinux.org>
To: Wolf <wolf@wolfsden.cz>
Cc: ~alpine/aports@lists.alpinelinux.org
Subject: Re: [PATCH] community/libtorrent-rasterbar: use c++17
Message-ID: <20211125142418.54fce87a@ncopa-desktop.lan>
In-Reply-To: <20211125113301.305966-1-wolf@wolfsden.cz>
References: <20211125113301.305966-1-wolf@wolfsden.cz>
X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.30; x86_64-alpine-linux-musl)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit

On Thu, 25 Nov 2021 12:33:01 +0100
Wolf <wolf@wolfsden.cz> wrote:

> ---
> Segfaults when using the default c++ standard (14). There is a upstream
> bug report stating that using 17 fixes the crash, and I can confirm
> that is the case for me as well.

I think the commit message should include an answer to why the change
is needed.

> I will report to upstream later when I have a reproduction example.

I don't know if this might be related:
https://github.com/arvidn/libtorrent/issues/6451

> 
> This should go to 3.15 as well. Not sure how to send a patch against
> it.

Thanks!

> 
>  community/libtorrent-rasterbar/APKBUILD | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/community/libtorrent-rasterbar/APKBUILD
> b/community/libtorrent-rasterbar/APKBUILD index
> 380536eccf..211446f209 100644 ---
> a/community/libtorrent-rasterbar/APKBUILD +++
> b/community/libtorrent-rasterbar/APKBUILD @@ -2,7 +2,7 @@
>  # Maintainer: August Klein <amatcoder@gmail.com>
>  pkgname=libtorrent-rasterbar
>  pkgver=1.2.14
> -pkgrel=2
> +pkgrel=3
>  pkgdesc="Feature complete C++ bittorrent implementation"
>  url="https://www.rasterbar.com/products/libtorrent"
>  arch="all !armv7 !aarch64 !x86" # on aarch64 and x86 failed to build
> @@ -28,7 +28,7 @@ build() {
>  		--localstatedir=/var \
>  		--enable-python-binding \
>  		--with-boost-system=boost_python$_py3ver \
> -		--with-std=c++14
> +		--with-cxx-standard=17
>  	make
>  }
>