~alpine/aports

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
5 4

[PATCH v2] testing/hdf4: new aport

Edd Salkield <edd@salkield.uk>
Details
Message ID
<20211126152421.28171-1-edd@salkield.uk>
DKIM signature
missing
Download raw message
Patch: +46 -0
https://www.hdfgroup.org/solutions/hdf4/
HDF4 is a data model, library, and file format for storing and managing data
---
Changes v1 -> v2:
 - Removed redundant patch
 - Updated config.guess
 - Added build and host configure flags
 - Updated pkgdesc
 - Removed question comment

 testing/hdf4/APKBUILD | 46 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 46 insertions(+)
 create mode 100644 testing/hdf4/APKBUILD

diff --git a/testing/hdf4/APKBUILD b/testing/hdf4/APKBUILD
new file mode 100644
index 0000000000..d0c8c3a7a5
--- /dev/null
+++ b/testing/hdf4/APKBUILD
@@ -0,0 +1,46 @@
# Contributor: Edd Salkield <edd@salkield.uk>
# Maintainer: Edd Salkield <edd@salkield.uk>
pkgname=hdf4
pkgver=4.2.15
pkgrel=0
pkgdesc="Data model, library, and file format for storing and managing data"
url="https://www.hdfgroup.org/solutions/hdf4/"
arch="all"
license="custom"
options="!check" # Upstream tests appear broken
depends_dev="zlib-dev jpeg-dev portablexdr-dev"
makedepends="$depends_dev gfortran bison flex"
checkdepends="diffutils" # Flags not supported by busybox diff are used
subpackages="$pkgname-dev $pkgname-doc"
source="https://support.hdfgroup.org/ftp/HDF/releases/HDF"$pkgver"/src/hdf-"$pkgver".tar.bz2"
builddir="$srcdir"/"hdf-$pkgver"

prepare() {
	default_prepare
	update_config_sub
	update_config_guess
}

build() {
	# This flag required to treat Fortran argument mismatch as a warning,
	# not an error.
	# This got fixed in master https://github.com/HDFGroup/hdf4/issues/1
	# but isn't fixed yet in the latest release.
	export FFLAGS="$FFLAGS -fallow-argument-mismatch"
	export LIBS="$LIBS -lportablexdr"
	./configure --prefix=/usr --build=$CBUILD --host=$CHOST
	make
}

check() {
	make check
}

package() {
	make DESTDIR="$pkgdir" install-recursive
	install -Dm644 COPYING "$pkgdir"/usr/share/licenses/"$pkgname"/COPYING
}

sha512sums="
7d4037800ef8950ed74f225355ef5458444bed26fc189fbbd2ce7d36009998013ac1f6ba5d4e60834acf8f6f73550357238745acc35e162679919400a48191e9  hdf-4.2.15.tar.bz2
"
-- 
2.34.1
Details
Message ID
<163795873462.14324.16389014921358879731.gitlab.27817.36ed4f9943c44bac014f5eec6cfea5dadf3eb309@listserv.local>
In-Reply-To
<20211126152421.28171-1-edd@salkield.uk> (view parent)
DKIM signature
missing
Download raw message
Seems like those arches are not supported, please disable them with `!arch` in the `arch=` variable

-- 
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/27817#note_194649
Edd Salkield <edd@salkield.uk>
Details
Message ID
<f7d4c4c66ff1835414efe2b45a0a8f5b09cff719.camel@salkield.uk>
In-Reply-To
<163795873462.14324.16389014921358879731.gitlab.27817.36ed4f9943c44bac014f5eec6cfea5dadf3eb309@listserv.local> (view parent)
DKIM signature
missing
Download raw message
I had a quick look around, and found that Fedora applies some downstream
patches to get hdf4 compiling on s390 and various ARM processes:
https://src.fedoraproject.org/rpms/hdf/tree/rawhide  We could consider
including some of these to see if it allows the build to succeed
instead.

If we were to do this, what would be the process to bring these patch
files in?  We could source them from Fedora, or have them included
locally.

Also, is there a way for me to test out whether this causes the builds
to succeed without resubmitting patches repeatedly?  I don't have access
to all the necessary hardware to do it all my end, and I'd ideally like
to submit some builds directly to the servers.
Details
Message ID
<163819790350.14324.5711378711444502446.gitlab.27817.36ed4f9943c44bac014f5eec6cfea5dadf3eb309@listserv.local>
In-Reply-To
<163795873462.14324.16389014921358879731.gitlab.27817.36ed4f9943c44bac014f5eec6cfea5dadf3eb309@listserv.local> (view parent)
DKIM signature
missing
Download raw message
Edd Salkield <edd@salkield.uk> replied via email:

```
I had a quick look around, and found that Fedora applies some downstream
patches to get hdf4 compiling on s390 and various ARM processes:
https://src.fedoraproject.org/rpms/hdf/tree/rawhide  We could consider
including some of these to see if it allows the build to succeed
instead.

If we were to do this, what would be the process to bring these patch
files in?  We could source them from Fedora, or have them included
locally.

Also, is there a way for me to test out whether this causes the builds
to succeed without resubmitting patches repeatedly?  I don't have access
to all the necessary hardware to do it all my end, and I'd ideally like
to submit some builds directly to the servers.


```

-- 
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/27817#note_195473
Details
Message ID
<163820009345.14324.7220461777495005164.gitlab.27817.36ed4f9943c44bac014f5eec6cfea5dadf3eb309@listserv.local>
In-Reply-To
<163819790350.14324.5711378711444502446.gitlab.27817.36ed4f9943c44bac014f5eec6cfea5dadf3eb309@listserv.local> (view parent)
DKIM signature
missing
Download raw message
Please add them locally and just resubmit the patchset/merge request. CI will take care of seeing if it builds on those arches

-- 
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/27817#note_195475
Details
Message ID
<164079360927.24590.4955710866079903591.gitlab.27817.61a211c54c69c37a3b68a042f49201b8759bf23e@listserv.local>
In-Reply-To
<20211126152421.28171-1-edd@salkield.uk> (view parent)
DKIM signature
missing
Download raw message
Sorry to bother you @mailinglist-bot,

but we've detected that this merge request hasn't seen any recent activity. If you need help or want to discuss your approach with developers you can ping `@team/mentors`. You can also ask on IRC on `#alpine-devel` on irc.oftc.net. If no further activity occurs in this MR, Alpine developers may close it in the future.

Thanks for your contribution.

-- 
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/27817#note_202049
Reply to thread Export thread (mbox)