~alpine/aports

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
9 6

[PATCH v2] testing/wlrobs: enable more arches, dmabuf

Details
Message ID
<20220115102617.17311-1-sir@cmpwn.com>
DKIM signature
missing
Download raw message
Patch: +2 -2
dmabuf is now supported without an upstream obs patch, and my earlier
obs changes fix obs on all architectures.
---
v2: rebase

 testing/wlrobs/APKBUILD | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/testing/wlrobs/APKBUILD b/testing/wlrobs/APKBUILD
index 7431e62265..3edd554cb4 100644
--- a/testing/wlrobs/APKBUILD
+++ b/testing/wlrobs/APKBUILD
@@ -4,9 +4,9 @@ pkgver=1.0
pkgrel=1
pkgdesc="obs-studio plugin that allows you to screen capture on wlroots"
url="https://hg.sr.ht/~scoopta/wlrobs"
arch="x86 x86_64" # obs-stduio not provided on other platforms
arch="all"
license="GPL-3.0-only"
makedepends="meson ninja obs-studio-dev wayland-dev"
makedepends="meson ninja obs-studio-dev wayland-dev libdrm-dev mesa-dev"
source="https://dev.alpinelinux.org/archive/wlrobs/wlrobs-$pkgver.tar.gz "
builddir="$srcdir/$pkgname-v$pkgver"
options="!check" # No tests provided
-- 
2.34.1
Details
Message ID
<164224814232.985.5216470625251787625.gitlab.29582.0ce4f81ff21a37b29ad1a5942e52cba85d6de406@listserv.local>
In-Reply-To
<20220115102617.17311-1-sir@cmpwn.com> (view parent)
DKIM signature
missing
Download raw message
Fails on s390x and armhf due to obs-studio(-dev) not packaged. lgtm otherwise

-- 
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/29582#note_206366
Details
Message ID
<CH68EUDK02V7.Q9WFCXV74M9W@kobayashi>
In-Reply-To
<164224814232.985.5216470625251787625.gitlab.29582.0ce4f81ff21a37b29ad1a5942e52cba85d6de406@listserv.local> (view parent)
DKIM signature
missing
Download raw message
I have a separate patch which should enable obs-studio on these arches.
Details
Message ID
<164224824427.985.1088517671800562323.gitlab.29582.0ce4f81ff21a37b29ad1a5942e52cba85d6de406@listserv.local>
In-Reply-To
<164224814232.985.5216470625251787625.gitlab.29582.0ce4f81ff21a37b29ad1a5942e52cba85d6de406@listserv.local> (view parent)
DKIM signature
missing
Download raw message
Drew DeVault <sir@cmpwn.com> replied via email:

```
I have a separate patch which should enable obs-studio on these arches.

```

-- 
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/29582#note_206368
Details
Message ID
<164227861955.985.10506773789924250846.gitlab.29582.bb4e40856d02642e0eb9d6405d2eae76e6cc0525@listserv.local>
In-Reply-To
<20220115102617.17311-1-sir@cmpwn.com> (view parent)
DKIM signature
missing
Download raw message
Depends on !29571.

-- 
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/29582#note_206524
Details
Message ID
<164487240858.985.9744405033192838434.gitlab.29582.793a5304b7293600dcaa85066e5e3060a86fd787@listserv.local>
In-Reply-To
<20220115102617.17311-1-sir@cmpwn.com> (view parent)
DKIM signature
missing
Download raw message
Sorry to bother you @mailinglist-bot,

but we've detected that this merge request hasn't seen any recent activity. If you need help or want to discuss your approach with developers you can ping `@maribu`. You can also ask on IRC on `#alpine-devel` on irc.oftc.net. If no further activity occurs in this MR, Alpine developers may close it in the future.

Thanks for your contribution.

-- 
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/29582#note_215443
Details
Message ID
<164487508502.985.13481034273021774658.gitlab.29582.eff7f82b87fb8be5a21c1f621739fb5016d471e2@listserv.local>
In-Reply-To
<20220115102617.17311-1-sir@cmpwn.com> (view parent)
DKIM signature
missing
Download raw message
On Sat, 15 Jan 2022 10:26:17 +0000, Drew DeVault wrote:
>  license="GPL-3.0-only"
> -makedepends="meson ninja obs-studio-dev wayland-dev"
> +makedepends="meson ninja obs-studio-dev wayland-dev libdrm-dev mesa-dev"

How is this related to enabling wlrobs on more arches? libdrm and mesa are needed only on non-x86_64? o.O

-- 
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/29582#note_215458
Details
Message ID
<164491328032.985.8823973081218967383.gitlab.29582.eff7f82b87fb8be5a21c1f621739fb5016d471e2@listserv.local>
In-Reply-To
<164487508502.985.13481034273021774658.gitlab.29582.eff7f82b87fb8be5a21c1f621739fb5016d471e2@listserv.local> (view parent)
DKIM signature
missing
Download raw message
On Sat, 15 Jan 2022 10:26:17 +0000, Drew DeVault wrote:
>  license="GPL-3.0-only"
> -makedepends="meson ninja obs-studio-dev wayland-dev"
> +makedepends="meson ninja obs-studio-dev wayland-dev libdrm-dev mesa-dev"

It's not. This commit does two things: enables more arches, and enables the dmabuf backend (which adds the dependencies).

-- 
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/29582#note_215491
Details
Message ID
<164491647181.985.14408121974989573664.gitlab.29582.eff7f82b87fb8be5a21c1f621739fb5016d471e2@listserv.local>
In-Reply-To
<164491328032.985.8823973081218967383.gitlab.29582.eff7f82b87fb8be5a21c1f621739fb5016d471e2@listserv.local> (view parent)
DKIM signature
missing
Download raw message
On Sat, 15 Jan 2022 10:26:17 +0000, Drew DeVault wrote:
>  license="GPL-3.0-only"
> -makedepends="meson ninja obs-studio-dev wayland-dev"
> +makedepends="meson ninja obs-studio-dev wayland-dev libdrm-dev mesa-dev"

Maybe it makes sense to split the two changes into one commit each to make it more obvious that adding `libdrm-dev` and `mesa-dev` is needed to also enable the dmabuf backend and not related to enabling it for other arches? (IMO they could still both be part of the same MR.)

But then again, the MR discussion now also serves as documentation for this.

In any case: I am still strongly in favor of getting this in :)

-- 
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/29582#note_215513
Details
Message ID
<164491729236.985.17183019080648842508.gitlab.29582.eff7f82b87fb8be5a21c1f621739fb5016d471e2@listserv.local>
In-Reply-To
<164491647181.985.14408121974989573664.gitlab.29582.eff7f82b87fb8be5a21c1f621739fb5016d471e2@listserv.local> (view parent)
DKIM signature
missing
Download raw message
On Sat, 15 Jan 2022 10:26:17 +0000, Drew DeVault wrote:
>  license="GPL-3.0-only"
> -makedepends="meson ninja obs-studio-dev wayland-dev"
> +makedepends="meson ninja obs-studio-dev wayland-dev libdrm-dev mesa-dev"

Superseded by this: https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/30934

-- 
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/29582#note_215515
Reply to thread Export thread (mbox)