This commit also adds a pre-install script to create the plugdev group,
otherwise udev rules would not work.
---
libu2f-host's pre-install script also printed out a message telling
users that they need to add themselves to the plugdev group to use the
USB tokens. Do we want to do that here? It seems to be uncommon.
main/libfido2/APKBUILD | 5 +++--main/libfido2/libfido2.pre-install | 2 ++
2 files changed, 5 insertions(+), 2 deletions(-)
create mode 100644 main/libfido2/libfido2.pre-install
diff --git a/main/libfido2/APKBUILD b/main/libfido2/APKBUILD
index 0a318571a0..b53a38b936 100644
--- a/main/libfido2/APKBUILD+++ b/main/libfido2/APKBUILD
@@ -1,12 +1,13 @@
# Contributor: Leo <thinkabit.ukim@gmail.com>
# Maintainer: Will Sinatra <wpsinatra@gmail.com>
pkgname=libfido2
-pkgver=1.9.0+pkgver=1.10.0pkgrel=0
pkgdesc="library for FIDO 2.0 functionality"
url="https://github.com/Yubico/libfido2"
arch="all"
license="BSD-2-Clause"
+install="$pkgname.pre-install"makedepends="cmake libcbor-dev openssl-dev zlib-dev eudev-dev linux-headers"
subpackages="$pkgname-dev $pkgname-doc fido2:fido"
source="$pkgname-$pkgver.tar.gz::https://github.com/Yubico/libfido2/archive/refs/tags/$pkgver.tar.gz"
@@ -40,5 +41,5 @@ fido() {
}
sha512sums="
-99edf9c52a871ed5dc3ab41ac07ca8a22670e7527c48ed69c096f001651e1e714bc3f1f55e22003cb66670fa4e851095834c2acd0e5b31887fad46bfb9f4b089 libfido2-1.9.0.tar.gz+ba03e25d3f42f11cec74dee48c853ae35d03600f24ca06d2b751840408a132290fe22461372ae42ae31419061a63d9908c20a2c0cf3c0c9c8dbc46c34916784f libfido2-1.10.0.tar.gz"
diff --git a/main/libfido2/libfido2.pre-install b/main/libfido2/libfido2.pre-install
new file mode 100644
index 0000000000..1ce958c1ea
--- /dev/null+++ b/main/libfido2/libfido2.pre-install
@@ -0,0 +1,2 @@
+#!/bin/sh+grep '^plugdev:' /etc/group >/dev/null || addgroup -S plugdev 2>/dev/null
--
2.35.1
On Wed, 02 Feb 2022 19:26:17 +0700, Umar Getagazov wrote:
> @@ -0,0 +1,2 @@> +#!/bin/sh> +grep '^plugdev:' /etc/group >/dev/null || addgroup -S plugdev 2>/dev/null
i think you should just add the group and `exit 0` at the bottom instead- like it's done in all the other pre-installs
--
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/30370#note_217530
On Wed, 02 Feb 2022 19:26:17 +0700, Umar Getagazov wrote:
> @@ -0,0 +1,2 @@> +#!/bin/sh> +grep '^plugdev:' /etc/group >/dev/null || addgroup -S plugdev 2>/dev/null
Umar Getagazov <umar@handlerug.me> replied via email:
```
On Mon Feb 21, 2022 at 3:24 PM +07, alice wrote:
> i think you should just add the group and `exit 0` at the bottom instead- like it's done in all the other pre-installs
Oh indeed, thanks for mentioning! I submitted a v2 with this fixed and
with a message when the package is installed (so that users know they
need to do this, taken from libu2f-host).
```
--
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/30370#note_217539