~alpine/aports

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
2

[PATCH] testing/bestline: new aport

Details
Message ID
<20220212235147.6661-1-sebastian@sebsite.pw>
DKIM signature
missing
Download raw message
Patch: +31 -0
https://github.com/jart/bestline
Minimal replacement for readline

Signed-off-by: Sebastian <sebastian@sebsite.pw>
---
 testing/bestline/APKBUILD | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)
 create mode 100644 testing/bestline/APKBUILD

diff --git a/testing/bestline/APKBUILD b/testing/bestline/APKBUILD
new file mode 100644
index 00000000..344e1853
--- /dev/null
+++ b/testing/bestline/APKBUILD
@@ -0,0 +1,31 @@
# Contributor: Sebastian Hudak <sebastian@sebsite.pw>
# Maintainer: Sebastian Hudak <sebastian@sebsite.pw>
pkgname=bestline
# No official release tagged yet; not ready to be moved out of testing.
pkgver=0.0_git20211108
_commit=8ab535e621b3848f8491469c2083c7ecb0df3e22
pkgrel=0
pkgdesc="Minimal replacement for readline"
url="https://github.com/jart/bestline"
arch="all"
license="BSD-2-Clause"
subpackages="$pkgname-dbg $pkgname-dev $pkgname-doc"
source="https://github.com/jart/bestline/archive/$_commit.tar.gz"
builddir="$srcdir/$pkgname-$_commit"
options="!check" # No test suite

build() {
	# Makefile doesn't use -fPIC, which is needed for shared library
	${CC:-gcc} $CFLAGS -fPIC -c -o bestline.o bestline.c
	${CC:-gcc} $LDFLAGS -shared -o libbestline.so bestline.o
}

package() {
	install -Dm644 bestline.o "$pkgdir"/usr/lib/bestline.o
	install -Dm755 libbestline.so "$pkgdir"/usr/lib/libbestline.so
	install -Dm644 bestline.h "$pkgdir"/usr/include/bestline.h
	install -Dm644 README.md "$pkgdir"/usr/share/doc/bestline/README.md
	install -m644 bestline.gif "$pkgdir"/usr/share/doc/bestline/bestline.gif
}

sha512sums="cd7411604c47a6910188394343b0388a0e580de891d332f4eea89f308888dfce5348fc94e826cb6cf960896ebf6272280cca90caca4537ca54e8719df61ec57b  8ab535e621b3848f8491469c2083c7ecb0df3e22.tar.gz"
-- 
2.34.1
Details
Message ID
<164471122533.985.17048679150607644532.gitlab.30832.e4759a0669a53d62493dc1b0f083a4403246afc0@listserv.local>
In-Reply-To
<20220212235147.6661-1-sebastian@sebsite.pw> (view parent)
DKIM signature
missing
Download raw message
On Sat, 12 Feb 2022 18:51:47 -0500, Sebastian wrote:
> +
> +package() {
> +	install -Dm644 bestline.o "$pkgdir"/usr/lib/bestline.o

what is the point of installing a non-linked .o object?

-- 
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/30832#note_214832
Details
Message ID
<164471124512.985.4089471381287937336.gitlab.30832.91f13a8093fdbed6d07a46688d877cb51750e7ee@listserv.local>
In-Reply-To
<20220212235147.6661-1-sebastian@sebsite.pw> (view parent)
DKIM signature
missing
Download raw message
On Sat, 12 Feb 2022 18:51:47 -0500, Sebastian wrote:
> +arch="all"
> +license="BSD-2-Clause"
> +subpackages="$pkgname-dbg $pkgname-dev $pkgname-doc"

generally we prefer not adding -dbg packages unless needed

-- 
via https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/30832#note_214833
Reply to thread Export thread (mbox)